Make the DB client a static var #42
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bfcf1d Add tests for client parameter combinatorics (#422) 4b6c9cd Add cluster to KW check in client constructor (#421) 0467d8a Consolidate requirements lists (#420) 56701f2 Python Client constructor update (#419) 251e34e Use Redis++ ConnectionObject to set TCP socket timeout (#413) c355ed2 Clarifying and Updating DataSet and Client API docs (#416) 33b7fd9 Update allowed special characters in SSDB name (#415) 83d413b Python Code coverage (#414) 6a25426 Retrieve the name of a dataset added to python API (#411) 3551b15 Run examples on commit (#412) 8e82e01 Multidb support for SmartRedis (#353) dd5e8fe Allow strings in Python run_script methods (#407) 90f6c87 Update RedisAI version in post commit checking (#408) 2fe3228 Expose MINBATCHTIMEOUT parameter in set_model interface (#406) 53def75 Model chunking support (#404) faf58b3 Add a contributing reference to SmartRedis (#395) cfbb69a Update RedisAI version to v1.2.7 (#402) 1a3e71c lcov update (#396) accfb15 Update to v0.4.2 6a4ef5a Update to v0.4.2 f8db229 Bump SR version number to 0.4.2 (#399) a464d3c Prepare changelog for release (#398) 123ea68 Update cibuildwheel version (#397) 0f3c943 Mitigate protected-access error by encapsulating factory checks (#393) 6413643 Extended section on dataset aggregation (#390) ea93e2f Update third-party software (#389) 10d2771 Fix Postmerge tests (#388) a0cfe37 Static branch fixups (#386) ba77808 Mitigate lint errors, apply formatters (#382) 1c355e6 Make testing more robust (#381) 39292dc update URI for installation instructions (#380) de066d0 Fix bad kwarg when launching server via UDS (#378) 7d58b13 Update language support matrix (#379) ea08165 Cleanup obsolete build and test files (#366) b729cf4 Reuse existing Redis connection when executing CLUSTER MAP command (#364) 616f474 Update to v0.4.1 01f56f7 Release 0.4.1 (#368) 39427e4 Assorted documentation updates (#367) 2213c1d Remove ParamSpec as Runtime Dep (#365) 5dd65f5 Add Typehints (#362) 4e72023 SmartRedis test system refactor (#356) 26493b3 Add support for Python 3.10 (#360) 11248bb Streamline setup.py with new build interface (#359) fd24155 Nuke srobject.from_pybind() (#358) 27eea1e Fix memory leak in C layer get_string_option() (#357) 754ba65 Update version of Hiredis (#351) 1d4c719 Remove debug statement (#352) f7db724 Parallelize build of examples (#349) 3cdbec6 Downgrade F2018 requirement to F2003 for NVHPC support (#346) 94f7188 Refactor SmartRedis build system (#341) 8138be1 Refactor to return default Fortran logical kind (#340) 913bdd0 Switch CI/CD pipeline to use MacOS 12 instead of 10.15 (#339) 511111d Spell fix DataSet Destructor C interface (#338) 74e3784 Multi-DB support: ConfigOptions repository (#303) 76e7761 third-party software support in Makefile (#331) 340ebb6 Update redis++ to 1.3.8 (#334) 87634da Add pip-install target to Makefile (#330) b5d73b1 Update to v0.4.0 2b4b5cc Prepare final updates for release 0.4.0 (#321) cb6c7b4 Prevent codecov status checks from failing (#317) 49e7cc3 Fix copy/paste error in to_str methods in C interface (#320) 6729a59 Template-based decorators for C layer (#312) 0eedd74 Template-based decorators for PyBind layer (#315) eefc5a1 Updated Python API summary (#314) 68a7a84 Pipeline dataset operations (#311) 188c12b Code coverage updates (#308) 256dd7f Fix multigpu set_model (#310) 7859560 Pipeline fixes (#309) b5a79a0 Fix list key prefix (#306) 9a00517 Fix assorted documentation errors and omissions (#305) fbcffc2 Add copyright headers to CI/CD YAML files (#304) aef85a9 Make Xarray an Optional Dependency (#302) 97751d8 Update version of redis-plus-plus (#296) fa2a2d8 Add dataset inspection of tensor dimensions (#299) 42cd8ed use_dataset_ensemble_prefix() (#298) f4e7119 Add missing throw documentation (#301) c2f62ac Add some missing error handling (#300) 7494164 Clean up pybind file (#297) 86b6d7a Add serialization support for Client and Dataset (#293) a90f051 Update to current PyBind version (#295) a213a41 Remove build_wheels_release.yml. 632caa1 SmartRedis Release v0.3.1 d3018c9 SmartRedis Release v0.3.0 b8d1ecf Merge pull request #130 from CrayLabs/develop 95ca568 Release v0.1.1 git-subtree-dir: 2023-01/smartsim/smartredis git-subtree-split: 6bfcf1deb0d726df75610fe8a352b9ecb13c44f7
Drawbacks: hard-coded configuration (clusterMode: false)
FoamScience
force-pushed
the
static_client
branch
from
a87ddbf to
8da4b0f
Compare
FoamScience
force-pushed
the
static_client
branch
from
a20e915 to
e3c6e84
Compare
FoamScience
force-pushed
the
static_client
branch
from
4dcc52f to
569ebf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Principle: Static members are initialized at global space; before starting the
mainfunction. So, each process can have a shared client for all smartSim function objects it instantiates.Drawback: No user customization, we're stuck with a client where cluster mode is turned off.
More artifacts:
developcommit