Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print better error msgs when drom fails to parse package name #186

Merged

Conversation

Karfroth
Copy link
Contributor

This is for issue 117.

At this point Drom does not mention which package has the problem when it fails to parse name. This PR improves error msg by checking the package section's dir field and file existence

if dir field is None, error msg will say a package does not have name in drom.toml file.
If dir field is given but file cannot be found, the msg will say package.toml is missing
if dir field is given, then it will print name field is missing.

@zapashcanon
Copy link
Member

Thanks !

@zapashcanon zapashcanon merged commit 5fb724b into OCamlPro:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants