Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js_of_ocaml debug flags #1246

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Halbaroth
Copy link
Collaborator

Currently, we compile the js worker without debug flags in our makefile.
I got an annoying bug while adapting the worker for Dolmen and without the
dev flags of dune, it was impossible to debug. I think it is better to
build it with the profile dev by default.

I also add more debugs flags at the toplevel of our worktree.

Currently, we compile the js worker without debug flags in our makefile.
I got an annoying bug while adapting the worker for Dolmen and without the
dev flags of `dune`, it was impossible to debug. I think it is better to
build it with the profile `dev` by default.

I also add more debugs flags at the toplevel of our worktree.
@Halbaroth
Copy link
Collaborator Author

Halbaroth commented Oct 3, 2024

Uhm, it seems that the node version does not compile correctly with the dev profile. This issue is already present on next:

dune build src/bin/js/main_text_js.bc.js --profile release 
node _build/default/src/bin/js/main_text_js.bc.js tests/everything/f1.ae 
File "tests/everything/f1.ae", line 159, characters 1-166: Valid (0.3200) (240 steps) (goal WP_create)

but

dune build src/bin/js/main_text_js.bc.js --profile dev 
node _build/default/src/bin/js/main_text_js.bc.js tests/everything/f1.ae 
Fatal error: exception Failure("caml_register_global: cannot locate Dynlink_compilerlibs.Binutils")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant