Rollback changes made in PR #340 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#340 We will be making manual syncs of students added to their course namespace to these OCP groups. We aren't tracking users in these groups via github so any changes to the group in the live cluster are overwritten by argoCD We will still be tracking the group manifets themselves albeit in a different ope dedicated repo: https://github.com/OCP-on-NERC/BU-RHOAI
larsks
approved these changes
Jan 25, 2024
dystewart
added a commit
to dystewart/BU-RHOAI
that referenced
this pull request
Jan 26, 2024
This is in responese to: OCP-on-NERC/nerc-ocp-config#352 Adding the groups as cluster scope resources to keep consistency with nerc-ocp-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#340
We will be making manual syncs of students added to their course namespace to these OCP groups. We aren't tracking users in these groups via github so any changes to the group in the live cluster are overwritten by argoCD
We will still be tracking the group manifets themselves albeit in a different ope dedicated repo: https://github.com/OCP-on-NERC/BU-RHOAI