Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1385 Desnagging #6

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

HDXDSYS-1385 Desnagging #6

wants to merge 11 commits into from

Conversation

IanHopkinson
Copy link
Collaborator

@IanHopkinson IanHopkinson commented Nov 26, 2024 •
edited
Loading

These are some miscellaneous fixes to HAPI Datamart which were identified during documentation and testing prior to launching the prototype

These include:

  1. Making sure the fs_check_info was always returned
  2. Removing HAPI resources from the lists since all the other lists can be used in queries.
  3. Replace filter_query and main_query with query in the search endpoint, this query is used in the package_search fq field
  4. Provide aliases of countries for groups and tags for vocab_Topics in field searches - to match language used in the list endpoint and common sense!
  5. Miscellaneous documentation improvements, a bit more testing and better benchmarking response.

teodorescuserban
teodorescuserban reviewed Nov 27, 2024
View reviewed changes
hdx_hapi/datamart/datamart_util.py
@@ -34,7 +34,7 @@ class SearchCommonEndpointParams(SearchPaginationParams):


async def search_pagination_parameters(
limit: Annotated[int, search_pagination_limit_query] = 10000,
limit: Annotated[int, search_pagination_limit_query] = 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

teodorescuserban
teodorescuserban approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@teodorescuserban teodorescuserban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok from my pov

tools/datamart_benchmarker.py Outdated Show resolved Hide resolved
tools/datamart_benchmarker.py
@@ -11,28 +12,36 @@

log = logging.getLogger(__name__)

DATAMART_ROOT_URL = 'http://localhost:8844'
LOCAL_DATAMART_ROOT_URL = 'http://localhost:8844'
DEV_DATAMART_ROOT_URL = 'https://dev.hapi-humdata-org.ahconu.org'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to avoid hardcoding here, or at least use it as default for os.getenv

tools/datamart_benchmarker.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodorescuserban teodorescuserban teodorescuserban approved these changes

@danmihaila danmihaila Awaiting requested review from danmihaila

@turnerm turnerm Awaiting requested review from turnerm

@alexandru-m-g alexandru-m-g Awaiting requested review from alexandru-m-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanHopkinson @teodorescuserban