Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] bc3_importer #35

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[14.0][ADD] bc3_importer #35

merged 1 commit into from
Sep 30, 2024

Conversation

szalatyzuzanna
Copy link

Importer of quotations in bc3 format.

@pedrobaeza
Copy link
Member

Hi, Zuzanna, thanks for this.

A nomenclature question: if this is only for importing, maybe it's better to call it bc3_importer, as connector may imply some kind of bidirectional communication.

Can you please also check the red CI

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 30, 2024
@pedrobaeza pedrobaeza changed the title [14.0][ADD]bc3_connector [14.0][ADD] bc3_importer Sep 30, 2024
pedrobaeza
pedrobaeza reviewed Sep 30, 2024
View reviewed changes
bc3_importer/__manifest__.py Outdated Show resolved Hide resolved
bc3_importer/__manifest__.py Outdated Show resolved Hide resolved
bc3_importer/__manifest__.py Outdated Show resolved Hide resolved
bc3_importer/__manifest__.py Outdated Show resolved Hide resolved
bc3_importer/data/bc3_version_data.xml Outdated Show resolved Hide resolved
bc3_importer/models/sale_order.py Outdated Show resolved Hide resolved
bc3_importer/security/bc3_file_security.xml Outdated Show resolved Hide resolved
bc3_importer/wizard/bc3_connector.code-workspace Outdated Show resolved Hide resolved
.copier-answers.yml Outdated Show resolved Hide resolved
bc3_importer/static/description/icon.png Outdated Show resolved Hide resolved
pedrobaeza
pedrobaeza approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-35-by-pedrobaeza-bump-nobump, awaiting test results.

@szalatyzuzanna
Copy link
Author

Thanks for the review!

@OCA-git-bot OCA-git-bot merged commit b733083 into OCA:14.0 Sep 30, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 198c845. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@jorgeglez1990 jorgeglez1990 jorgeglez1990 approved these changes

@adasatorres adasatorres adasatorres approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@szalatyzuzanna @pedrobaeza @OCA-git-bot @jorgeglez1990 @adasatorres