Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] stock_inventory_valuation_report #299

Merged
merged 14 commits into from
Feb 14, 2024
Merged

[14.0][MIG] stock_inventory_valuation_report #299

merged 14 commits into from
Feb 14, 2024

Conversation

aleuffre
Copy link

@aleuffre aleuffre commented Jan 2, 2024 •
edited
Loading

Supersedes #292

The last three commits add:

  • Remove today's date from the report footer to avoid confusion
  • The report prints the variant's name, instead of the product template's name
  • the UoM in both XLSX and PDF reports

ps-tubtim and others added 10 commits January 2, 2024 17:57
@ps-tubtim @aleuffre
[12.0][ADD]stock_inventory_valuation_report
e82a14b
@aleuffre
[FIX] Standard price incorrectly calculated on historic value
e32de8e
@aleuffre
[ADD] Reference and Barcode column in stock inventory valuation report
f2d52d4
@sysadminmatmoz @aleuffre
Added translation using Weblate (Slovenian)
f24e5bc
@pedrocs-exo @aleuffre
Added translation using Weblate (Portuguese)
32d500c
@ypapouin @aleuffre
Added translation using Weblate (French)
1db06a3
@SimoRubi @aleuffre
[FIX] stock_inventory_valuation_report: show quantity in the past for…
47d0165 
… currently not available products
@francesco-ooops @aleuffre
Added translation using Weblate (Italian)
392e03c
@mymage @aleuffre
Translated using Weblate (Italian)
e1efe8a 
Currently translated at 100.0% (39 of 39 strings)

Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_inventory_valuation_report
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_inventory_valuation_report/it/
@solo4games @aleuffre
[IMP] stock_inventory_valuation_report: black, isort, prettier
e6c3bbe
@aleuffre aleuffre force-pushed the 14.0-mig-stock_inventory_valuation_report branch 9 times, most recently from e612378 to 15a3274 Compare January 3, 2024 10:34
@francesco-ooops
Copy link
Contributor

@geomer198 could you review?

geomer198
geomer198 suggested changes Jan 5, 2024
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix code by my comments.

stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py Show resolved Hide resolved
stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py Show resolved Hide resolved
stock_inventory_valuation_report/wizard/stock_quantity_history.py Outdated Show resolved Hide resolved
stock_inventory_valuation_report/wizard/stock_quantity_history.py Outdated Show resolved Hide resolved
stock_inventory_valuation_report/tests/test_stock_inventory_valuation_report.py Show resolved Hide resolved
stock_inventory_valuation_report/static/src/js/stock_inventory_valuation_report_backend.js Outdated Show resolved Hide resolved
stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py Show resolved Hide resolved
stock_inventory_valuation_report/reports/stock_inventory_valuation_report.py Outdated Show resolved Hide resolved
stock_inventory_valuation_report/wizard/stock_quantity_history.py Show resolved Hide resolved
@aleuffre aleuffre force-pushed the 14.0-mig-stock_inventory_valuation_report branch 3 times, most recently from fa9e7cb to fc64a89 Compare January 8, 2024 10:40
@francesco-ooops
Copy link
Contributor

@geomer198 better now?

also requesting review from @jbaudoux and @rousseldenis

geomer198
geomer198 approved these changes Jan 9, 2024
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francesco-ooops
Copy link
Contributor

@OCA/logistics-maintainers can this be merged?

@aleuffre aleuffre force-pushed the 14.0-mig-stock_inventory_valuation_report branch from fc64a89 to 586b4ea Compare February 7, 2024 09:38
@aleuffre aleuffre force-pushed the 14.0-mig-stock_inventory_valuation_report branch from fef2555 to 4f3edb2 Compare February 12, 2024 11:33
@rousseldenis
Copy link
Contributor

/ocabot migration stock_inventory_valuation_report

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Feb 12, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#119) has not been updated to reference the current pull request because a previous pull request (#292) is not closed.
Perhaps you should check that there is no duplicate work.
CC @solo4games

francesco-ooops
francesco-ooops approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional is ok!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@rousseldenis good to go?

@francesco-ooops
Copy link
Contributor

@pedrobaeza can it be merged based on existing reviews?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-299-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a05707b into OCA:14.0 Feb 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b009cc5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geomer198 geomer198 geomer198 approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.