Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] mail_drop_target_mailing_trace #1438

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ajaniszewska-dev
Copy link
Contributor

@ajaniszewska-dev ajaniszewska-dev commented Sep 11, 2024

Provide access rights for the model mass_mailing.model_mailing_trace
so that there is no error when user tries to drop email.

This is needed due to odoo commit:
odoo/odoo@95743d5

@ajaniszewska-dev ajaniszewska-dev changed the title [IMP] mail_drop_target: introduce group to control mailing_trace mode… [IMP] mail_drop_target: add group to control mailing_trace model access Sep 11, 2024
@ajaniszewska-dev ajaniszewska-dev changed the title [IMP] mail_drop_target: add group to control mailing_trace model access [ADD] mail_drop_target_mailing_trace Sep 23, 2024
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO would make sense to reference Odoo commit odoo/odoo@95743d5 here.

],
"installable": True,
"application": True,
"auto_install": False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"auto_install": False,
"auto_install": True,

Provide access rights for the model mass_mailing.model_mailing_trace
so that there is no error when user tries to drop email.

This is needed due to odoo commit:
odoo/odoo@95743d5
@ajaniszewska-dev
Copy link
Contributor Author

IMO would make sense to reference Odoo commit odoo/odoo@95743d5 here.

@grindtildeath updated in commit msg/PR description, plus commit mentioned already in module's readme.

@ajaniszewska-dev ajaniszewska-dev marked this pull request as ready for review September 24, 2024 06:52
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's an error on travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants