[16.0][IMP] mail_debrand: Add remove_href_odoo_special_case #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joao-p-marques, @pedrobaeza, |
|
I see the other PR #1215 was added to fix the same issue, but the msg is cut "Have a look at the ", I don't really like that behavior. 
However, my solution is not generic, tell me if you think we should not need to handle a specific case like this then this PR should be closed. |
|
Fix #1090 |
cuongnmtm
force-pushed
the
16.0-imp-remove_href_odoo_special_case
branch
2 times, most recently
from
f50749e
to
7695c5b
Compare
When rendering the template, the remove_href_odoo function will remove the parent of the <a> element which has 'odoo.com' in href. There is a problem with mail.template "New Portal Signup", the parent element is almost the whole content hence most of the content will be removed. remove_href_odoo_special_case() is added to handle this special case.t push
cuongnmtm
force-pushed
the
16.0-imp-remove_href_odoo_special_case
branch
from
7695c5b
to
b3ad288
Compare
|
I will close this because it doesn't work with translation... |
|
Does #1272 work for you? |
|
Oh, I see you are targeting this template: https://github.com/odoo/odoo/blob/597fc00/addons/auth_signup/data/mail_template_data.xml#L146-L151 |
|
I've extended my fix to cover this case. See the second commit on #1272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering the template, the remove_href_odoo function will remove the parent of the element which has 'odoo.com' in href.
There is a problem with mail.template "New Portal Signup", the parent element is almost the whole content hence most of the content will be removed.
remove_href_odoo_special_case() is added to handle this special case.