Skip to content

Commit

Permalink
Revert "server_environment: Fix value assignation in compute from def…
Browse files Browse the repository at this point in the history
…ault"

This reverts commit cc56952.

The fix is breaking other modules, the original problem must be fixed in
mail_environment.
  • Loading branch information
gurneyalex committed Jun 27, 2024
1 parent 338be02 commit 7da94cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server_environment/models/server_env_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def _compute_server_env_from_config(self, field_name, options):

def _compute_server_env_from_default(self, field_name, options):
if options and options.get("compute_default"):
self[field_name] = getattr(self, options["compute_default"])()
getattr(self, options["compute_default"])()

Check warning on line 257 in server_environment/models/server_env_mixin.py

View check run for this annotation

Codecov / codecov/patch

server_environment/models/server_env_mixin.py#L257

Added line #L257 was not covered by tests
else:
default_field = self._server_env_default_fieldname(field_name)
if default_field:
Expand Down

0 comments on commit 7da94cb

Please sign in to comment.