Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] auth_admin_passkey: Migration to 18.0 #710

Closed

Conversation

moncefarajdal
Copy link

No description provided.

legalsylvain and others added 30 commits October 15, 2024 11:29
…ion if user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…s the same password as the admin user, sending a mail to admin user.
… installation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…xxx']

[REF] res_users.py : same call to self.pool in other res_users class.
[ADD] Test OCA#1 to OCA#5 to avoid regression;
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
codeagencybe and others added 4 commits October 15, 2024 11:29
In the res_users.py file, the `ignore_totp` session variable is now set based on the value of the `auth_admin_passkey_ignore_totp` configuration option. If the option is enabled, the `ignore_totp` session variable is set to True. This ensures that the `_mfa_url` method returns None when `ignore_totp` is True, effectively bypassing the 2FA check.
return subject, "<pre>{}</pre>".format(body)
return subject, f"<pre>{body}</pre>"`

looks lighter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. something has been wrong in the github proposal !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain I fixed this issue. Now I have the following issue:
AttributeError: 'dict' object has no attribute 'encode' on line:
password = hashlib.sha512(password.encode()).hexdigest()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks quite unrelated, don't you think ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain Yes your solution fixed the previous problem. It's not related to this one.

@moncefarajdal moncefarajdal changed the title 18.0 mig auth admin passkey [18.0] [MIG] auth_admin_passkey: Migration to 18.0 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.