Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth_saml: feat: set timeout for lock on update provider #677

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

vrenaville
Copy link

No description provided.

@vrenaville vrenaville marked this pull request as draft August 8, 2024 11:20
@sbidoul sbidoul changed the title feat: set timeout for lock on update provider auth_saml: feat: set timeout for lock on update provider Aug 18, 2024
@sbidoul sbidoul added this to the 14.0 milestone Aug 18, 2024
@vrenaville vrenaville marked this pull request as ready for review August 29, 2024 08:19
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection on my side. Needs testing in real.

Copy link

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen together, LGTM so far

Comment on lines +424 to +425
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.flush()
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants