Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] auth_oauth_autologin: Migration to 16.0 #627

Open
wants to merge 11 commits into
base: 16.0
Choose a base branch
from

Conversation

benwillig
Copy link

No description provided.

@benwillig benwillig force-pushed the 16.0-mig_auth_oauth_autologin-bwi branch from 1f280a0 to e573263 Compare March 20, 2024 14:59
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@sbidoul sbidoul changed the title [MIG] auth_oauth_autlogin: Migration to 16.0 [MIG] auth_oauth_autologin: Migration to 16.0 Aug 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Aug 11, 2024

/ocabot migration auth_oauth_autologin

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2024
22 tasks
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Aug 11, 2024

@benwillig In the past I think we could pass a ?no_autologin to the /web/login route to prevent autologin.

This does not seem to work anymore. Maybe it's just me?

@benwillig
Copy link
Author

@sbidoul Yes no_autologin should avoid the redirection but it doesn't look to be working properly. I will take a look at it.

@benwillig benwillig force-pushed the 16.0-mig_auth_oauth_autologin-bwi branch from e573263 to 5df0507 Compare August 28, 2024 12:44
@benwillig
Copy link
Author

@sbidoul keep_blank_values=True was missing when parsing the query. It should work as expected now.

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants