[16.0][FIX] sale_order_type: Avoid unwanted triggering of compute functions #3321
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
force-pushed
the
16.0-fix-sale_order_type_compute
branch
from
7c0f268
to
272d6cb
Compare
Having account.move._compute_journal_id overriden with an added dependency to sale_type_id is messing with computation triggers, because compute functions depending on journal_id will get recomputed, potentially overwriting existing value, as is the case with bank account on account.payment. Use instead the hook to search for default journal, in order to return the journal defined on sale order type to its compute function.
grindtildeath
force-pushed
the
16.0-fix-sale_order_type_compute
branch
from
272d6cb
to
e3a4c5e
Compare
| # trigger unwanted recomputation of partner_bank_id on vendor bills | ||
| self.env.add_to_compute( | ||
| self.env["account.move"]._fields["journal_id"], record | ||
| ) |
There was a problem hiding this comment.
Careful, AFAIK, when using add_to_compute, the field dependencies aren't recomputed unless you explicitly call modified, too.
This was referenced Sep 24, 2024
henrybackman
approved these changes
Sep 25, 2024
|
Since Odoo accepted my fix and fast tracked it, I'm not sure if this change is still needed ❓ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having account.move._compute_journal_id overriden with an added dependency to sale_type_id is messing with computation triggers, because compute functions depending on journal_id will get recomputed, potentially overwriting existing value, as is the case with bank account on account.payment.
Use instead the hook to search for default journal, in order to return the journal defined on sale order type to its compute function.