[16.0][MIG] sale_coupon_order_line_link: Migration to version 16.0 #151

pilarvargas-tecnativa · 2023-09-18T21:57:28Z

TODO: Renamed to sale_loyalty_order_line_link and script for migration

Please @chienandalu can you check it? If it is correct I rename it

TT34237

TT39003

Signed-off-by pedrobaeza

…website

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-promotion-13.0/sale-promotion-13.0-website_sale_coupon_page Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-13-0/sale-promotion-13-0-website_sale_coupon_page/

This way, you can put richer text with multi-lines as description. TT33564

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-promotion-15.0/sale-promotion-15.0-website_sale_coupon_page Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-website_sale_coupon_page/

…+ Migration to 16.0 TT44378

Signed-off-by pedrobaeza

Currently translated at 100.0% (15 of 15 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_order_line_link/it/

If a third module adds an extra discount scope, we should: - Allow integration returning always at least an empty object - Allow compatibility by inheritance hooking into the method that defines the scoped lines. TT36131

In some cases the `recompute_coupon_lines` method could lead to miss the previously created links. We want to ensure those links at the end of such method. TT40205

TT37311

Currently translated at 100.0% (15 of 15 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_order_line_link/it/

chienandalu

Yes, the rename would be correct IMO.

Some remarks:

sale_coupon_order_line_link/models/sale_order.py

sale_coupon_order_line_link/reports/sale_report.py

chienandalu · 2023-09-19T15:05:32Z

sale_coupon_order_line_link/views/sale_order_views.xml

                    <group name="promo_info" string="Promotions">
-                        <field
+                        <!-- <field


This view needs to be revised because the fields have changed and may need to be added to the sale.order model to display them.

These fields no longer exist in the sale.order model nor have they been renamed, I would have to add them to the model to get the promotion/coupon applied and in the case that a coupon is generated also add a field to display those generated coupons. I don't know if this is necessary to complete the functionality of the module or if this would be a parallel functionality.

sale_coupon_order_line_link/views/sale_order_views.xml

sale_coupon_order_line_link/models/sale_order.py

sale_coupon_order_line_link/views/sale_order_views.xml

chienandalu

Add the migration script

chienandalu · 2023-09-21T07:11:12Z

sale_coupon_order_line_link/migrations/16.0.1.0.0/post-migration.py

+def _fill_reward_id_field(env):
+    for line in env["sale.order.line"].filtered("loyalty_program_id"):
+        line.reward_id = env["reward.program"].search(
+            [["program_id", "=", line.loyalty_program_id.id]]
+        )


Better do this in pre and with sql for performance and to avoid to trigger ORM operations

I doubted whether such a field will already exist in pre

It probably won't. You should try to pre-create the column:

ALTER TABLE sale_order_line ADD COLUMN IF NOT EXISTS reward_id INTEGER;

…_link + Migration to version 16.0 TT44349

pilarvargas-tecnativa · 2023-09-21T08:25:16Z

Continued in #152

OCA-git-bot and others added 30 commits October 3, 2022 22:04

Initialize 16.0 branch

e64f336

[IMP] update dotfiles [ci skip]

e287ef4

[IMP] update dotfiles [ci skip]

9d1f6f2

[ADD] sale_coupon_chatter: New module

79c141e

TT34237

[MIG] sale_coupon_chatter: Renamed to coupon_chatter + migration to 15.0

f7122ea

TT39003

[UPD] Update coupon_chatter.pot

9a5f540

[UPD] README.rst

866a41c

[UPD] Update coupon_chatter.pot

5de846b

[IMP] coupon_chatter: pre-commit stuff

26c690a

[MIG] coupon_chatter: Migration to 16.0

dafaaee

Merge PR OCA#142 into 16.0

033aad9

Signed-off-by pedrobaeza

[UPD] Update coupon_chatter.pot

240d1c4

[UPD] addons table in README.md

afc57b3

[UPD] README.rst

7e6246e

[ADD] setup.py

6a08a37

[ADD] website_sale_coupon_page: New module to show the promotions on …

54b54ae

…website

[IMP] website_sale_coupon_page: Switch public name to HTML

59fa960

This way, you can put richer text with multi-lines as description. TT33564

[IMP] website_sale_coupon_page: black, isort, prettier

0e02187

[MIG] website_sale_coupon_page: Migration to 15.0

7e165cf

[UPD] Update website_sale_coupon_page.pot

35f5ce6

[UPD] README.rst

4db1f35

[IMP] website_sale_coupon_page: pre-commit stuff

c676888

[MIG] website_sale_coupon_page: Renamed to website_sale_loyalty_page …

e6e53d2

…+ Migration to 16.0 TT44378

[UPD] README.rst

2c2b58d

[UPD] Update coupon_chatter.pot

e2b32d4

Merge PR OCA#149 into 16.0

1e40029

Signed-off-by pedrobaeza

[UPD] Update coupon_chatter.pot

1267b1d

[UPD] Update website_sale_loyalty_page.pot

78880e1

ilyasProgrammer and others added 14 commits September 15, 2023 11:23

[MIG] sale_coupon_order_line_link: Migration to 14.0

bd6516e

Added translation using Weblate (Italian)

a82ba95

[FIX] sale_coupon_order_line_link: missing links

3ced290

In some cases the `recompute_coupon_lines` method could lead to miss the previously created links. We want to ensure those links at the end of such method. TT40205

[MIG] sale_coupon_order_line_link: Migration to 15.0

fbe0b54

TT37311

[UPD] Update sale_coupon_order_line_link.pot

04ab82f

[UPD] README.rst

f6952d3

[UPD] README.rst

b093897

[IMP] sale_coupon_order_line_link: pre-commit stuff

7a1015d

pilarvargas-tecnativa marked this pull request as draft September 18, 2023 21:57

pilarvargas-tecnativa force-pushed the 16.0-mig-sale_coupon_order_line_link branch from b4cfcfd to 4527b89 Compare September 19, 2023 14:48

pilarvargas-tecnativa marked this pull request as ready for review September 19, 2023 14:52

chienandalu suggested changes Sep 19, 2023

View reviewed changes

pilarvargas-tecnativa force-pushed the 16.0-mig-sale_coupon_order_line_link branch from 4527b89 to 0e58cb0 Compare September 20, 2023 10:34

chienandalu suggested changes Sep 20, 2023

View reviewed changes

sale_coupon_order_line_link/models/sale_order.py Outdated Show resolved Hide resolved

sale_coupon_order_line_link/views/sale_order_views.xml Outdated Show resolved Hide resolved

pilarvargas-tecnativa force-pushed the 16.0-mig-sale_coupon_order_line_link branch from 0e58cb0 to b8929e6 Compare September 20, 2023 14:18

chienandalu reviewed Sep 20, 2023

View reviewed changes

pilarvargas-tecnativa force-pushed the 16.0-mig-sale_coupon_order_line_link branch 2 times, most recently from 2229958 to 4f462f9 Compare September 20, 2023 16:17

chienandalu suggested changes Sep 21, 2023

View reviewed changes

[MIG] sale_coupon_order_line_link: Renamed to sale_loyalty_order_line…

061e5a5

…_link + Migration to version 16.0 TT44349

pilarvargas-tecnativa closed this Sep 21, 2023

pilarvargas-tecnativa force-pushed the 16.0-mig-sale_coupon_order_line_link branch from 4f462f9 to 061e5a5 Compare September 21, 2023 07:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_coupon_order_line_link: Migration to version 16.0 #151

[16.0][MIG] sale_coupon_order_line_link: Migration to version 16.0 #151

pilarvargas-tecnativa commented Sep 18, 2023 •

edited

Loading

chienandalu left a comment

chienandalu Sep 19, 2023

pilarvargas-tecnativa Sep 19, 2023

pilarvargas-tecnativa Sep 20, 2023

chienandalu left a comment

chienandalu Sep 21, 2023

pilarvargas-tecnativa Sep 21, 2023

chienandalu Sep 21, 2023

pilarvargas-tecnativa commented Sep 21, 2023

[16.0][MIG] sale_coupon_order_line_link: Migration to version 16.0 #151

[16.0][MIG] sale_coupon_order_line_link: Migration to version 16.0 #151

Conversation

pilarvargas-tecnativa commented Sep 18, 2023 • edited Loading

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Sep 19, 2023

Choose a reason for hiding this comment

pilarvargas-tecnativa Sep 19, 2023

Choose a reason for hiding this comment

pilarvargas-tecnativa Sep 20, 2023

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Sep 21, 2023

Choose a reason for hiding this comment

pilarvargas-tecnativa Sep 21, 2023

Choose a reason for hiding this comment

chienandalu Sep 21, 2023

Choose a reason for hiding this comment

pilarvargas-tecnativa commented Sep 21, 2023

pilarvargas-tecnativa commented Sep 18, 2023 •

edited

Loading