Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] sale_promotion_discount_in_field #148

Conversation

solo4games
Copy link

@solo4games solo4games commented Aug 25, 2023

Fix view of fields "Free product" and "apply discount" and "max discount amount" which are visible while they are not applicable to fixed price module
Fix double Apply Discount view on form

@solo4games solo4games force-pushed the 14.0-t2742-sale_promotion_discount_in_field-fix_view_of_not_applicable_fields branch 3 times, most recently from c25bf13 to 8f717f6 Compare August 28, 2023 17:56
Copy link
Member

@GabbasovDinar GabbasovDinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, seems Ok

@solo4games solo4games force-pushed the 14.0-t2742-sale_promotion_discount_in_field-fix_view_of_not_applicable_fields branch from 01d4128 to 9dabd9d Compare August 30, 2023 06:32
…uct" and "apply discount" and "max discount amount"

This field are visible while they are not applicable to fixed price module
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

cc @chienandalu

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@pedrobaeza this one too is a minor fix to view, thanks!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Aug 31, 2023
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-148-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf7934e into OCA:14.0 Aug 31, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 542bd9b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants