[14.0][FIX] sale_promotion_discount_in_field #146
Conversation
Volodiay622
force-pushed
the
14.0-t2752-sale_promotion_discount_in_field-fix_discount_apply
branch
2 times, most recently
from
6694cf8
to
fa9fb19
Compare
| program = self.env["coupon.program"].search(program_domain) | ||
| if ( | ||
| program | ||
| and program.reward_type == "discount_line" |
There was a problem hiding this comment.
I think this conditions need add in search domain on the 15th code lines.
Then like this:
if program:
...
return error_status
return super().apply_coupon(order, coupon_code)
|
|
||
| def apply_coupon(self, order, coupon_code): | ||
| # OVERRIDE to apply the program to the order without reward lines | ||
| error_status = {} |
There was a problem hiding this comment.
I think this variable not need set because error_status use, if program is exists.
| 2475.0, | ||
| "The order total with programs should be 2475.00", | ||
| ) | ||
| self.assertEqual(result, {}) |
| error_status = {} | ||
| program_domain = order._get_coupon_program_domain() | ||
| program_domain = expression.AND( | ||
| [program_domain, [("promo_code", "=", coupon_code)]] |
There was a problem hiding this comment.
Please change domain like this.
program_domain = expression.AND(
[program_domain, [("promo_code", "=", coupon_code), ("reward_type", "=", "discount_line"), ("promo_applicability", "!=", "on_next_order")]]
)
There was a problem hiding this comment.
Functional OK!
Before this PR, "max customer applications" from sale_coupon_limit could be bypassed with reward type = discount in line
@chienandalu good for you?
|
This PR has the |
when Promo code used, promotion was not added to Applied Promo Program of current order.
Volodiay622
force-pushed
the
14.0-t2752-sale_promotion_discount_in_field-fix_discount_apply
branch
from
17169c0
to
9cea208
Compare
|
@pedrobaeza merge please? |
| @@ -0,0 +1 @@ | |||
| "This module should be renamed sale_coupon_discount_in_field in future migrations for naming consistency." | |||
|
What a great day to merge this nice PR. Let's do it! |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at d5df43a. Thanks a lot for contributing to OCA. ❤️ |
when Promo code used, promotion was not added to Applied Promo Program of current order.