Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] base_report_to_printer: Add company rules for printers and servers #368

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] base_report_to_printer: Add company rules for printers and servers #368

wants to merge 1 commit into from

Conversation

GabbasovDinar
Copy link
Member

@GabbasovDinar GabbasovDinar commented Oct 9, 2024 •
edited
Loading

Context:

  • I have a printer server located at "My Company" in New York, also have "Another company" in Brooklyn, I don't want to be sent to print from Brooklyn to New York printer

Before this PR:

  • All printers, jobs, servers available for all companies.

After this PR:

  • If the company is specified on the printer server, only related printers are available for the company.

@GabbasovDinar GabbasovDinar force-pushed the 16.0-t3977-base_report_to_printer-multi-company-printers branch from b0d5f66 to 7c5eab1 Compare October 14, 2024 17:49
hoangtrann
hoangtrann approved these changes Oct 16, 2024
View reviewed changes
Copy link

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@GabbasovDinar GabbasovDinar force-pushed the 16.0-t3977-base_report_to_printer-multi-company-printers branch from 7c5eab1 to 32bffc3 Compare November 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geomer198 geomer198 geomer198 approved these changes

@hoangtrann hoangtrann hoangtrann approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GabbasovDinar @OCA-git-bot @hoangtrann @geomer198