-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17.0 migration printer zpl2 #362
base: 17.0
Are you sure you want to change the base?
Conversation
3986218
to
9fe55e4
Compare
<field name="printer_id" /> | ||
<field | ||
name="label_id" | ||
context="{'default_model_id': active_model_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this domain="[('model_id', '=', active_model_id)]" to the label_id field because I tested this pull request on my localhost and encountered a problem: the label_id field is always empty, even though I have set a label for the current model. This is happening because the current context doesn't have active_model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aminambk
Seems like @MarcLSubteno did the change.
Could you please re-review and resolve this?
9fe55e4
to
0159854
Compare
Hello, |
Can you cherry pick #343 ? |
0159854
to
f0d05a8
Compare
@micheledic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
Functionally installs, but haven't had a chance to test.
@OCA/reporting-engine-maintainers |
Well, tests and pre-commit are failing. I will do a rebase and see if it is solved, otherwise, we will need some actions from the author. /ocabot rebase |
* [FIX] printer_tray: Allow to call print_option with no report * [ADD] Add printer_zpl2 module
This command causes Godex printers in GZPL emulation not to print the label, this might be a firmware bug (tested on G500 Z1.00E ) OCA Transbot updated translations from Transifex
Copied from https://github.com/subteno-it/python-zpl2, as there has been new release (1.2.1) that breaks current code without clear source (no commit on the repo). As the amount of code is not too much, we put it on the module itself, being able to control the whole chain, and to reduce the code with the considerations of current Odoo version. This commit has as author the main commmiter of the library repo.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/
Currently translated at 6.0% (12 of 200 strings) Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/it/
Currently translated at 6.0% (12 of 200 strings) Translation: report-print-send-15.0/report-print-send-15.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-15-0/report-print-send-15-0-printer_zpl2/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Currently translated at 100.0% (200 of 200 strings) Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/
Currently translated at 81.5% (163 of 200 strings) Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/it/
Currently translated at 100.0% (200 of 200 strings) Translation: report-print-send-16.0/report-print-send-16.0-printer_zpl2 Translate-URL: https://translation.odoo-community.org/projects/report-print-send-16-0/report-print-send-16-0-printer_zpl2/it/
Congratulations, PR rebased to 17.0. |
f0d05a8
to
12feecc
Compare
@MarcLSubteno |
12feecc
to
dd7794b
Compare
Fix pre-commit error on #347