Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] base_report_to_printer: out of connection fallback to client #346

Merged

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Jan 31, 2024

If the CUPS server isn't available the user won't be able to do anything to print the report they need.

At last we can give them the chance to have a fallback behavior downloading the document.

cc @Tecnativa TT47134

take a look @sergio-teruel

@chienandalu chienandalu force-pushed the 15.0-imp-base_report_to_printer-fallback-print branch 5 times, most recently from b019d23 to daff704 Compare March 26, 2024 14:44
If the CUPS server isn't available the user won't be able to do anything
to print the report they need.

At last we can give them the chance to have a fallback behavior
downloading the document.

TT47134
@chienandalu chienandalu force-pushed the 15.0-imp-base_report_to_printer-fallback-print branch from daff704 to cb493cd Compare April 3, 2024 09:01
@chienandalu chienandalu marked this pull request as ready for review April 3, 2024 09:01
Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@pedrobaeza pedrobaeza added this to the 15.0 milestone Aug 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-346-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 88aa2f4 into OCA:15.0 Aug 26, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2833a15. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-base_report_to_printer-fallback-print branch August 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants