Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pim: Migration to 16.0 + remove completeness dependency #184

Open
wants to merge 92 commits into
base: 16.0
Choose a base branch
from

Conversation

myrrkel
Copy link

@myrrkel myrrkel commented Jun 16, 2024

This PR contains initOS migrations:

  • pim
  • product_attribute_set_completeness
  • attribute_set_completeness

and ADD pim_product_attribute_set_completeness

I added a new module pim_product_attribute_set_completeness to remove product_attribute_set_completeness dependency from pim.
This dependency was added to display 2 fields in the product list view. This was adding too much complexity to maintain the pim app because product_attribute_set_completeness depends on attribute_set_completeness, witch depends on component_event (from the 'connector' repository) witch requires cachetools python module.

pim_product_attribute_set_completeness is now adding product_attribute_set_completeness and add the fields in the pim product list view.

Cédric Pigeon and others added 30 commits July 17, 2023 10:33
* Split computed methods in attribute.set.owner.mixin.
* Use assertRaisesRegex in tests to check for exact error message.
* Improve readability of event listner skip_if conditions.
add migration script : fields have been removed from v13 -> v14
@myrrkel myrrkel changed the title [16.0][MIG] pim: Migration to 16.0 + remove completeness dependecy [16.0][MIG] pim: Migration to 16.0 + remove completeness dependency Jun 17, 2024
@simahawk
Copy link
Contributor

Is this replacing completely #165
If yes, @dsolanki-initos fine for you? Could you have a look?
Yet, the history does not look good.
Regarding the refactoring... @rousseldenis could you please give a feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants