[IMP] enable database manager #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OCA repos, sometimes there are incompatible modules. Or, at least, modules that introduce pollute others' behaviors. When doing functional tests of a PR and the DB already contains all addons for the branch, it's easy to find out a bug that really won't be a bug in the current PR, but instead a side effect of another addon in the same repo. Many times, that addon isn't even used in production and the flaky use case is irrelevant. It's helpful to have the possibility of installing an empty database. This way, only the wanted addons can be installed, and there's less chance for unwanted side-effects. On a recent real use case that we have recorded, a user lost 30 minutes in the functional review, only to uninstall modules that polluted the one he wanted to test. At the end, there were still failures that we're not sure if belong to the important module. For these reasons, I'm configuring Odoo runboat instances to have the database manager enabled by default, with a standard password: `admin`. I took the chance to add a couple of good default parameters for any database.
|
But then what is going to drop those user-created databases on runboat? |
|
So yeah, I'm -1 on this, as this changes the promises of this image. If we want a runboat db with only |
|
I created sbidoul/runboat#94 to track this. |
|
OK, sorry. I assumed the whole postgres pod was volatile too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OCA repos, sometimes there are incompatible modules. Or, at least, modules that introduce pollute others' behaviors.
When doing functional tests of a PR and the DB already contains all addons for the branch, it's easy to find out a bug that really won't be a bug in the current PR, but instead a side effect of another addon in the same repo. Many times, that addon isn't even used in production and the flaky use case is irrelevant.
It's helpful to have the possibility of installing an empty database. This way, only the wanted addons can be installed, and there's less chance for unwanted side-effects.
On a recent real use case that we have recorded, a user lost 30 minutes in the functional review, only to uninstall modules that polluted the one he wanted to test. At the end, there were still failures that we're not sure if belong to the important module.
For these reasons, I'm configuring Odoo runboat instances to have the database manager enabled by default, with a standard password:
admin.I took the chance to add a couple of good default parameters for any database.
@moduon @rafaelbn