-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] product_account_multicompany_default propagate product category accounts #650
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @yajo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an expert but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. It looks pretty well. However, I can see no changes on README.
Since this impacts in the module functionality, please extend the description and usage sections. This way we'll know better how to test this functionally.
57b8025
to
740d06b
Compare
Thanks for your review @yajo . I have updated README mentioning propagation of accounting fields on product category. |
Hi @yajo it's Ok for you ?? can you merge this PR :) |
Hello @pedrobaeza, could you merge this PR ? |
/ocabot merge major |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-650-by-pedrobaeza-bump-major. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! |
@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-650-by-yajo-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@santostelmo can you check the failures on merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review 👍
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
740d06b
to
d727d23
Compare
Ci failures fixed. I increased unit test coverage. |
This PR has the |
Propagate product category accounts from the current company to all
other companies where you have access rights.