Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] product_account_multicompany_default propagate product category accounts #650

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

santostelmo
Copy link

Propagate product category accounts from the current company to all
other companies where you have access rights.

@OCA-git-bot
Copy link
Contributor

Hi @yajo,
some modules you are maintaining are being modified, check this out!

Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks pretty well. However, I can see no changes on README.

Since this impacts in the module functionality, please extend the description and usage sections. This way we'll know better how to test this functionally.

@santostelmo santostelmo force-pushed the 16.0-imp-product_account_multicompany_default-propagate-product_categ_accounts branch from 57b8025 to 740d06b Compare June 24, 2024 09:41
@santostelmo
Copy link
Author

Thanks for the contribution. It looks pretty well. However, I can see no changes on README.

Since this impacts in the module functionality, please extend the description and usage sections. This way we'll know better how to test this functionally.

Thanks for your review @yajo . I have updated README mentioning propagation of accounting fields on product category.

@cyrilmanuel
Copy link

Hi @yajo it's Ok for you ?? can you merge this PR :)

@cyrilmanuel
Copy link

Hello @pedrobaeza, could you merge this PR ?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 1, 2024
@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-650-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 1, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-650-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-650-by-yajo-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 2, 2024
Signed-off-by yajo
@OCA-git-bot
Copy link
Contributor

@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-650-by-yajo-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@gurneyalex
Copy link
Member

@santostelmo can you check the failures on merge?

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 👍

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@santostelmo santostelmo force-pushed the 16.0-imp-product_account_multicompany_default-propagate-product_categ_accounts branch from 740d06b to d727d23 Compare November 25, 2024 06:45
@santostelmo
Copy link
Author

@santostelmo can you check the failures on merge?

Ci failures fixed. I increased unit test coverage.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants