Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[NEW] Setup database template / unaccent on travis and runbot #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mileo
Copy link
Member

@mileo mileo commented Dec 6, 2021

Hi,

We are trying to run OCA travis tests with the unaccent extension:

https://github.com/OCA/l10n-brazil/pull/1701/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485

It was only possible when we added this new optional parameter that allows you to use a template database in the test setup.

@mileo
Copy link
Member Author

mileo commented Dec 6, 2021

Unfortunately the unaccent fix does not propagate to the runbot, would it be necessary to add these environment variables to the runbot?

https://runbot2.odoo-community.org/runbot/static/build/3520430-1701-228d66/logs/job_20_test_all.txt

CC: @moylop260 @gurneyalex

Thanks in advance

@mileo mileo changed the title [NEW] SETUP_TEMPLATE_DB [NEW] Setup database template / unaccent on travis and runbot Dec 8, 2021
@gurneyalex
Copy link
Member

runbot is dead. Please open a new issue on runboat if needed.

@gurneyalex gurneyalex closed this Mar 11, 2022
@gurneyalex gurneyalex reopened this Mar 11, 2022
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with me

@gurneyalex gurneyalex self-requested a review March 11, 2022 12:54
@rvalyi
Copy link
Member

rvalyi commented Mar 29, 2022

@mileo before we depend on Travis specific things while Travis is already dead, I approve this if you propose something equivalent for Runboat here https://github.com/OCA/oca-ci/tree/master/bin and if it gets approved.
Otherwise it's going to be a shot in the foot for the migration from v12... Alternatively the test can probably be written with a mock to avoiding tweaking the Porstgres CI.

@mileo
Copy link
Member Author

mileo commented Apr 23, 2022

@mileo before we depend on Travis specific things while Travis is already dead, I approve this if you propose something equivalent for Runboat here https://github.com/OCA/oca-ci/tree/master/bin and if it gets approved. Otherwise it's going to be a shot in the foot for the migration from v12... Alternatively the test can probably be written with a mock to avoiding tweaking the Porstgres CI.

We will work on that ASAP.

@mileo
Copy link
Member Author

mileo commented Apr 23, 2022

@mileo before we depend on Travis specific things while Travis is already dead, I approve this if you propose something equivalent for Runboat here https://github.com/OCA/oca-ci/tree/master/bin and if it gets approved. Otherwise it's going to be a shot in the foot for the migration from v12... Alternatively the test can probably be written with a mock to avoiding tweaking the Porstgres CI.

I have verified that many OCA projects still using travis (13/14) and i don't think i's a problem to merge it.

And from what I analyzed in the runboat/oca-ci code it is simpler and less parameterizable than maintainer-quality-tools keeping the same db, which apparently won't cause the same problem, but it's necessary to test to have 100% of assurance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants