Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[REF] requirements: Add xlsxwriter package #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moylop260
Copy link
Contributor

@moylop260 moylop260 commented Dec 21, 2016

New package requirement from odoo#10.0

@moylop260 moylop260 self-assigned this Dec 21, 2016
@dreispt
Copy link
Member

dreispt commented Dec 22, 2016

Why don't we pip install the requirements.txt after cloning the Odoo project?

@moylop260
Copy link
Contributor Author

moylop260 commented Dec 22, 2016

Maybe for historical reasons.
Older version of odoo didn't have requirements.txt
Your idea is a good approach.
Could you create the issue and add the tag "needs help"?

We will need:

  • Remove lxml with a sed command because is installed from apt. (Maybe other package with similar case)
  • Add tests case for all versions >=8.0
    - Use alternative requirements if there is not present in that version >=8.0 now has requirements.txt file
  • Check if a package is installed from main image of travis to remove it
  • Check if a package require developer tools package to compile it

However, if currently we don't have the candidate to work on this behaivour this pr helps to avoid add in all requirements.txt of oca projects for version 10.0 this package manually.

@lmignon
Copy link
Contributor

lmignon commented Dec 22, 2016

@moylop260 #343 uses the requirements.txt from Odoo...

@moylop260
Copy link
Contributor Author

moylop260 commented Dec 22, 2016

Maybe not for all cases
Here you can see a installation from mqt yet:

https://travis-ci.org/OCA/maintainer-quality-tools/jobs/167031005#L232

@lmignon
Copy link
Contributor

lmignon commented Dec 22, 2016

@moylop260 good catch.. I was pretty sure that was the case in this PR. Internally we always pip install every modules in our projects and for odoo we use `pip install -r https://raw.githubusercontent.com/odoo/odoo/9.0/requirements.txt' to install the official python requirements.

@moylop260
Copy link
Contributor Author

Yes we do

@osvalr
Copy link

osvalr commented Dec 22, 2016

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants