Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] l10n_ch_qr_bill_without_amount #741

Conversation

santostelmo
Copy link
Contributor

Allows you to print QR invoices without a predefined amount. The QR invoice without an amount is based on the payment mode field Qr Bill Without Amount

@santostelmo santostelmo force-pushed the 16.0-add-l10n_ch_qr_bill_without_amount branch from a883784 to b8d17a3 Compare November 13, 2024 08:08
@TDu TDu changed the title [ADD] l10n_ch_qr_bill_without_amount [16.0][ADD] l10n_ch_qr_bill_without_amount Nov 15, 2024
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a very similar module in 13.0 and 17.0
https://github.com/OCA/l10n-switzerland/tree/17.0/l10n_ch_qr_no_amount
It does not have the possible configuration with the payment mode, but it would make sense to merge them in the future IMO

compute="_compute_qr_bill_amount",
)

@api.depends("amount_residual")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@api.depends("amount_residual")
@api.depends("amount_residual", "payment_mode_id.qr_bill_without_amount")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TDu , what a pity I didn't find the model in version 17 before. It makes more sense to backport this module and create a glue module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TDu I just realized that the 17.0 module is not working as expected.
When we scan th QR we still see the amount:
image
You can try it here : https://qr-rechnung.net/#/scan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing that is not possible is to print invoice with and without amount in batch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, can we keep in the readme or roadmap of this module that the other one exists and we should try to merge them or regroup their common functionality in some way...
Also I think there still is a missing field in the api.depends (see comment above)

Copy link
Contributor

@grindtildeath grindtildeath Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we scan th QR we still see the amount

That's a bug of the module... (EDIT: Fixed in #745 )

Another thing that is not possible is to print invoice with and without amount in batch

Feel free to provide an improvement on the existing module, there's no reason to have two different modules for that

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in my comment above, the same module already exists, so we should close this and eventually improve the existing module.

@santostelmo
Copy link
Contributor Author

santostelmo commented Nov 28, 2024

As written in my comment above, the same module already exists, so we should close this and eventually improve the existing module.

It is not the same module. How can I answer the specific need of the client to send invoices with and without amount by email ? That is not possible in the module l10n_ch_qr_no_amount. Probably if you see a way to merge that feature in l10n_ch_qr_no_amount we could refactor that in the future.

@grindtildeath
Copy link
Contributor

@santostelmo The module provides the report without amount. Choosing which report has to be sent by e-mail is a matter of integrating it for your customer.

@santostelmo
Copy link
Contributor Author

santostelmo commented Nov 28, 2024

@santostelmo The module provides the report without amount. Choosing which report has to be sent by e-mail is a matter of integrating it for your customer.

Customer must be able to mix both reports. For example:
I select a set of invoices in tree view. I print report and I get a single file with invoices with and without amount.
I don't know how to achieve that with l10n_ch_qr_no_amount..

I'm thinking to convert that dev in customer specific.

@grindtildeath
Copy link
Contributor

@santostelmo To me, what you describe is a specific requirement.

You can handle that in a specific module that depends on l10n_ch_qr_no_amount, in order to keep the customization of the report (ie no amount encoded, hash marks displayed instead of empty amount on the slip) in the OCA.

@santostelmo
Copy link
Contributor Author

Thanks @grindtildeath . I close this PR.

Quick note for related project. This module should be moved to specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants