Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_br_account_payment_brcobranca #3226

Merged

Conversation

antoniospneto
Copy link
Contributor

@antoniospneto antoniospneto commented Jul 25, 2024

Migração do módulo l10n_br_account_payment_brcobranca versão 15.0 para 16.0
Feito a partir da PR: #3224

Depende de:

Edit:
Apesar de não depender diretamente do módulo l10n_br_account, quando instalados juntos pode haver conflitos que devem se resolvidos, para facilitar a migração do account, é melhor aguardar o merge lá primeiro.

@rvalyi
Copy link
Member

rvalyi commented Jul 25, 2024

a mudança do TransactionCase ela podia ter sido feita no PR da v15. Mas enfim para ta OK mesmo assim. Valeu demais pelo trabalho!

@rvalyi
Copy link
Member

rvalyi commented Jul 25, 2024

/ocabot migration l10n_br_account_payment_brcobranca

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 25, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#2153) has not been updated to reference the current pull request because a previous pull request (#2967) is not closed.
Perhaps you should check that there is no duplicate work.
CC @ygcarvalh

@rvalyi
Copy link
Member

rvalyi commented Jul 25, 2024

/ocabot migration l10n_br_account_payment_brcobranca

mbcosta and others added 21 commits July 29, 2024 18:50
@antoniospneto antoniospneto force-pushed the 16.0-mig-l10n_br_account_payment_brcobranca branch from e964bda to 80df2c9 Compare July 29, 2024 21:50
@renatonlima renatonlima requested a review from mbcosta July 30, 2024 12:48
@rvalyi
Copy link
Member

rvalyi commented Jul 31, 2024

Pessoal, no PR de migracao do l10n_br_account #2865 rolou varios "conflitos" nos testes: tive que desativar uns 2 testes do l10n_br_payment_order, os testes do do l10n_br_cnab_structure e o hook do l10n_br_cnab_structure...

Nisso como a migraçao do l10n_br_account ta impedindo a migraçao de varios outros modulos bem importante e que ja eh bem dificil finalizar a migraçao do l10n_br_account, proponho da gente segurar um pouco o merge desse modulo para nao dar mais tiros no pe ate a gente fazer o merge do l10n_br_account.

cc @renatonlima @antoniospneto @mbcosta

@antoniospneto
Copy link
Contributor Author

Pessoal, no PR de migracao do l10n_br_account #2865 rolou varios "conflitos" nos testes: tive que desativar uns 2 testes do l10n_br_payment_order, os testes do do l10n_br_cnab_structure e o hook do l10n_br_cnab_structure...

Nisso como a migraçao do l10n_br_account ta impedindo a migraçao de varios outros modulos bem importante e que ja eh bem dificil finalizar a migraçao do l10n_br_account, proponho da gente segurar um pouco o merge desse modulo para nao dar mais tiros no pe ate a gente fazer o merge do l10n_br_account.

cc @renatonlima @antoniospneto @mbcosta

Por mim, tudo bem, vou deixa em rascunho então enquanto aguardamos o l10n_br_account.
Estou estudando as mudanças no módulo account nativo, para poder colaborar mais na migração.

@antoniospneto antoniospneto marked this pull request as draft July 31, 2024 17:54
@rvalyi
Copy link
Member

rvalyi commented Aug 18, 2024

@antoniospneto eu consegui resolver os problemas de incompatibilidade no l10n_br_account: era o fato de usar testes do country_code com BR em vez de testar a presença de fiscal_operation_id. Deixei ate pronto para ser revisado: #2865

Nisso ta tudo bem a gente fazer o merge do l10n_br_account_payment_brcobranca. Pode botar para ready for review de novo?

cc @mbcosta @renatonlima

@rvalyi rvalyi marked this pull request as ready for review August 18, 2024 01:58
@rvalyi
Copy link
Member

rvalyi commented Aug 18, 2024

eu ate botei pronto para ser revisado eu mesmo.

@rvalyi
Copy link
Member

rvalyi commented Aug 22, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3226-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2d1d930 into OCA:16.0 Aug 22, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2c52658. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.