Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] product_harmonized_system: ACL with an empty group #267

Conversation

AndreuOForgeFlow
Copy link

in v17, a warning appears when you have an ACL with an empty group, so I added base.group_user there

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via, @luc-demeyer,
some modules you are maintaining are being modified, check this out!

Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏿 thank you for the improvement

@pedrobaeza pedrobaeza added this to the 17.0 milestone Mar 14, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-267-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 975c492 into OCA:17.0 Mar 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a532641. Thanks a lot for contributing to OCA. ❤️

@AndreuOForgeFlow AndreuOForgeFlow deleted the 17.0-imp-product_harmonized_system-acl_empty_group branch March 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants