Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] intrastat_product: skip invoice with non EU country #264

Conversation

MarinaAForgeFlow
Copy link

@MarinaAForgeFlow MarinaAForgeFlow commented Jan 31, 2024

Added check to skip the invoice if the method _get_partner_country has resulted in an error because of the country not being a EU country.
Also added hooks to allow having empty values if the field is not required. For example, in the Danish intrastat report some fields are not required under certain circumstances.

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LG

@MarinaAForgeFlow
Copy link
Author

Hi @joao-p-marques. I see that you worked on the intrastat_product migration to v16 and that you refactored the code for the method "_get_partner_country". In this PR I have added a check to skip the invoice if the partner country is outside the EU, however, I am wondering now if my fix is really necessary.
In the case where the partner country is the same as the company country, the invoice is skipped and the message is logged instead of added to the notedict, as it is not an error but a reason to filter out. Do you believe that this should be done too for the case where the partner country does not belong to the EU?

Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@github-actions github-actions bot closed this Jul 7, 2024
@MarinaAForgeFlow
Copy link
Author

Hi @alexis-via , is there any possibility that we can get this PR re-opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants