Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] intrastat refunds. #251

Closed
wants to merge 1 commit into from
Closed

[16.0][FIX] intrastat refunds. #251

wants to merge 1 commit into from

Conversation

ljsalvatierra-factorlibre
Copy link

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre commented Nov 24, 2023 •
edited
Loading

Modify transaction ID for the following cases:

  • Dispatches:
    • out_invoice B2B: 11
    • out_invoice B2C: 12
    • in_refund: 21
  • Arrivals:
    • out_refund: 21
    • in_invoice: 11 Don't propagate intrastat transaction to refund.
      Add some tests.
      Remove unused files.

Related PR in l10n-spain: OCA/l10n-spain#3322

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via, @luc-demeyer,
some modules you are maintaining are being modified, check this out!

ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Nov 24, 2023
@ljsalvatierra-factorlibre
[FIX] intrastat refunds.
2a0fd6f 
Related PR: OCA/intrastat-extrastat#251
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Nov 24, 2023
Closed
aritzolea
aritzolea approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@aritzolea aritzolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@ljsalvatierra-factorlibre
[FIX] intrastat refunds.
5cd4971 
Modify transaction ID for the following cases:
* Dispatches:
  * out_invoice B2B: 11
  * out_invoice B2C: 12
  * in_refund: 21
* Arrivals:
  * out_refund: 21
  * in_invoice: 11
Don't propagate intrastat transaction to refund.
Add some tests.
Remove unused files.
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre marked this pull request as ready for review November 29, 2023 09:50
MayteGLC
MayteGLC approved these changes Nov 29, 2023
View reviewed changes
Copy link

@MayteGLC MayteGLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ljsalvatierra-factorlibre
Copy link
Author

Hi, could you please review this @pedrobaeza @victoralmau ? And its related PR OCA/l10n-spain#3322

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 15, 2023
pedrobaeza
pedrobaeza reviewed Dec 15, 2023
View reviewed changes
intrastat_product/wizards/account_move_reversal.py
res = super()._prepare_default_reversal(move)
res.update(
{
"intrastat_transport_id": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain why these changes, and also add docstring putting this reason/explanation for documenting the code.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is based on -> https://sede.agenciatributaria.gob.es/Sede/aduanas/intrastat-obligaciones-estadisticas/noticias-interes/nuevos-codigos-naturaleza-transaccion-intrastat.html

On the other hand, I don't understand why code 12 doesn't match with this other documentation... -> https://www.intrastat.com/aeat/normativa/intrastat/tabla-naturaleza-de-la-transaccion-para-intrastat.php

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this in code.

intrastat_product/models/intrastat_product_declaration.py Show resolved Hide resolved
@ljsalvatierra-factorlibre
Copy link
Author

Hi @pedrobaeza could you review please the comments from @SoniaViciana ?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoniaViciana SoniaViciana SoniaViciana left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@MayteGLC MayteGLC MayteGLC approved these changes

@aritzolea aritzolea aritzolea approved these changes

Assignees
No one assigned
Labels
approved question ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ljsalvatierra-factorlibre @OCA-git-bot @pedrobaeza @aritzolea @SoniaViciana @MayteGLC @dreispt