-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] intrastat_product - remove default company for intrastat regions #245
[IMP] intrastat_product - remove default company for intrastat regions #245
Conversation
Hi @alexis-via, @luc-demeyer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The localisation modules should set the regions based upon the country_id.
I suggest that the localisation modules inherit from the accounting setup wizard In order to ensure that this is also the case when adding a new company.
There seems to be something weird with the READMEs digest. |
@pedrobaeza These changes were made by pre-commit. I let it passed since I was not sure it's intended or not. |
434c012
to
74519b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have downloaded the branch locally, undoing the digest changes, and they are not done. I think you have an old tooling in your local. Please update it.
As this is now fixed, merging it:
/ocabot merge patch
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at aed1246. Thanks a lot for contributing to OCA. ❤️ |
Right now, regions have a company by default but if we have two belgian companies or two french companies, it's not logical to have the regions declared in each company nor "user-friendly" to have to edit default regions on the "first" company to have it on each company.
For example, while migrating l10n_be_intrastat_product and testing on an empty database, my regions were created in one company and not available on the second belgian company. I had to go on the first company to edit the regions and make it available for the second one.