Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] intrastat_product - remove default company for intrastat regions #245

Merged

Conversation

jdidderen-noviat
Copy link
Contributor

@jdidderen-noviat jdidderen-noviat commented Nov 12, 2023

Right now, regions have a company by default but if we have two belgian companies or two french companies, it's not logical to have the regions declared in each company nor "user-friendly" to have to edit default regions on the "first" company to have it on each company.

For example, while migrating l10n_be_intrastat_product and testing on an empty database, my regions were created in one company and not available on the second belgian company. I had to go on the first company to edit the regions and make it available for the second one.

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via, @luc-demeyer,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@luc-demeyer luc-demeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The localisation modules should set the regions based upon the country_id.
I suggest that the localisation modules inherit from the accounting setup wizard In order to ensure that this is also the case when adding a new company.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 12, 2023
@pedrobaeza
Copy link
Member

There seems to be something weird with the READMEs digest.

@jdidderen-noviat
Copy link
Contributor Author

@pedrobaeza These changes were made by pre-commit. I let it passed since I was not sure it's intended or not.
Should I remove these ?

@pedrobaeza pedrobaeza force-pushed the 16.0-region_not_company_default branch from 434c012 to 74519b2 Compare November 12, 2023 12:22
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have downloaded the branch locally, undoing the digest changes, and they are not done. I think you have an old tooling in your local. Please update it.

As this is now fixed, merging it:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-245-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 60f6713 into OCA:16.0 Nov 12, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aed1246. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants