[13.0][ADD]product_harmonized_system_heading & product_harmonized_system_heading_stock #229
Conversation
GuillemCForgeFlow
force-pushed
the
13.0-add-product_harmonized_system_heading_
branch
from
b7f7464 to
35b699b
Compare
|
Hi @pedrobaeza As seen in www.tariffnumber.com, H.S. Codes will always have a Heading: By having this module, we could have a better structure on those. |
There was a problem hiding this comment.
About the improvements on the existing module, they are OK. About the new module, not sure if very useful, as at the end, you don't manage the HS codes. You just assign them to products. And what is a blocking point is to add extra constraints that requires context tricks in other unrelated modules. The technique if you want to keep such restriction if to not apply it when on test mode (config["test_enable"]) and not testing the constraint itself.
GuillemCForgeFlow
force-pushed
the
13.0-add-product_harmonized_system_heading_
branch
2 times, most recently
from
bd23920 to
c6123f8
Compare
|
Hi @pedrobaeza Regarding the use of the module, I've done it in a way that you don't need to install the module to still be using the H.S. Codes provided by the We have a customer need that requires us to structure H.S. Codes in such a way and I thought that it could be a good improvement to the current OCA structure. If you don't agree, I will just close it and set it in on a custom module. WDYT? |
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| if not config["test_enable"] or self.env.context.get("check_hs_code_heading"): |
There was a problem hiding this comment.
Instead of this, just do hs_code_heading_id a computed writable field, but removing the error if not found.
There was a problem hiding this comment.
I've just changed it now to work in the following way:
- When an H.S. Code is created, it will try to find the corresponding Heading, if none is found, it will automatically create a new one, instead of triggering an error to then manually create the Heading.
- If we edit the Local Code, we also call the
_get_hs_code_heading_idmethod to get the new Heading.
Doing it like this, we don't need to adapt any tests and by optionally having this module, the user won't need to go through any additional steps.
GuillemCForgeFlow
force-pushed
the
13.0-add-product_harmonized_system_heading_
branch
3 times, most recently
from
7f1b8ed to
74ebd62
Compare
- extract `name_get` logic in another method to be inherited - remove _sql_constraints and change it for an api constrains method to have a better control and so that there no global duplicates (those that are not company specific) - replaced `replace` method for strip()
GuillemCForgeFlow
force-pushed
the
13.0-add-product_harmonized_system_heading_
branch
from
74ebd62 to
f83e953
Compare
New module to have a better structure on H.S. Codes. If installed, H.S. Codes will require from a H.S. Heading to be created first.
Glue module between product_harmonized_system_heading and stock in order to add the needed Menu Item. Just as done in the `product_harmonized_system_stock` module.
GuillemCForgeFlow
force-pushed
the
13.0-add-product_harmonized_system_heading_
branch
from
f83e953 to
efbe8ef
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
New module to have a better structure on H.S. Codes. If installed, H.S. Codes will require a H.S. Heading to be created first.
cc @ForgeFlow