[16.0][ADD] hr_attendance_ip_check: IP-based attendance validation #189
Conversation
kongkea-aditi
changed the title
There was a problem hiding this comment.
There's already an open PR for v17 for a module(also having the same module name - hr_attendance_ip_check) in this repo itself (#168). It was opened quite a while ago - in June.The changes added through that PR does implement the same feature in a much better way. It takes into account CIDR for IP address checking and also it manages the whitelisted IPs in a much more efficient way.Also, the overall coding standards are better. So, it could have been simply backported to v16 rather than having the module developed through this PR.
| @@ -0,0 +1,2 @@ | |||
| """IP-based Attendance Check module initialization.""" | |||
| import logging | ||
| from odoo import models, api, _ | ||
|
|
||
| _logger = logging.getLogger(__name__) |
| def create(self, vals_list): | ||
| """Override create to validate IP before creating attendance records.""" | ||
| if not vals_list: | ||
| return {'warning': _('No valid attendance records to create')} |
There was a problem hiding this comment.
No need to return warning for missing vals_list , it would be there. Anyways warning cannot be used here like this
| validation_result = employee._validate_ip_address('check_in') | ||
|
|
||
| if isinstance(validation_result, dict): | ||
| return validation_result |
There was a problem hiding this comment.
Warnings cannot be returned from create functions its only used for onchange functions. Instead of warnings throw ValidationError directly from _validate_ip_address function
|
|
||
| def write(self, vals): | ||
| """Override write to validate IP before updating attendance records.""" | ||
| if 'check_out' in vals: |
There was a problem hiding this comment.
Check for both check in and check out as check in time can also be modified later and accordingly pass check_in/check_out on line 31
| for attendance in self: | ||
| validation_result = attendance.employee_id._validate_ip_address('check_out') | ||
| if isinstance(validation_result, dict): | ||
| return validation_result |
There was a problem hiding this comment.
Similarly to create functions, warnings cannot be returned
|
|
||
| def _validate_ip_address(self, action_type='attendance'): | ||
| """Validate if current IP is allowed for attendance actions.""" | ||
| if not self.env['ir.config_parameter'].sudo().get_param( |
There was a problem hiding this comment.
Make use of const_eval(after importing it)
from odoo.tools.safe_eval import const_eval
const_eval(self.env['ir.config_parameter'].sudo().get_param('hr_attendance.ip_check_enabled', 'False')))
| _logger.error("Error getting IP address: %s", str(e), exc_info=True) | ||
| return None | ||
|
|
||
| def _validate_ip_address(self, action_type='attendance'): |
There was a problem hiding this comment.
return validation errors instead of warnings in this function
|
|
||
| # Validate IP first | ||
| ip_validation = self._validate_ip_address(action_type) | ||
| if isinstance(ip_validation, dict): |
There was a problem hiding this comment.
Validation error should be raised so no need to checking if its a dictionary
| config_parameter='hr_attendance.ip_check_enabled', | ||
| help="Enable IP address validation for attendance check-in/check-out" | ||
| ) | ||
| whitelist_ips = fields.Char( |
There was a problem hiding this comment.
Instead of having a comma separated list of IPs which would be very difficult to handle in long run, some other way should be used to handle the IPs.For ex: The allowed IPs can be stored on a per employee basis
[16.0][ADD] hr_attendance_ip_check: IP-based attendance validation
This module extends HR attendance to validate check-in/check-out based on IP address.
Features:
Test scenario: