[FIX] [16.0] hr_contract_update_overtime: Reorganize Leaves across Contracts + Message #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rafaelbn, |
|
Ping me when I can test it @Shide ! ❤️ Thank you! 😄 |
fcvalgar
reviewed
Jul 23, 2024
| @@ -38,6 +38,9 @@ You can Update Overtime in different ways: | |||
| - Header button on Contract History form view | |||
| - Header button on Contract form view | |||
There was a problem hiding this comment.
- Header button on Contract form view is visible if the user is responsible HR for the employee
fcvalgar
approved these changes
Jul 23, 2024
…attendance If you run this module's tests while it's being installed for the 1st time, `hr_holidays_attendance` will enter its test scope and add extra constrains to which leaves are considered for employees. If we don't follow those constrains, the tests fail. Thus here I'm using that module lazily, while not being strictly required as a dependency. If installed, I fulfill the data required for it to work, and then tests are more resilient. @moduon MT-6583
Done |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ad32323. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MT-6583 @moduon @rafaelbn @loida-vm @fcvalgar please reivew if you want 😄