-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Opening a directory using the right click open action #245
Conversation
@etobella Please, can you verify why the build was not successful |
Probably we need to update the template of dms... |
/ocabot rebase |
Congratulations, PR rebased to 12.0. |
c38a433
to
a7f5bf2
Compare
@etobella Please can you check why runboat/build is pending? |
/ocabot rebase |
The root directory can't be opened using the contextual action menu (`open`) Impacted versions: 12.0 and above Steps to reproduce: Go to "DMS directories" in the partner form view Create a new root directory Right-click and choose `Open` Current behavior: Odoo raises an error `TypeError: record is null` Expected behavior: Open the directory like if we click on the `Open` button in the right section (Document preview)
Congratulations, PR rebased to 12.0. |
Just rebase 😉 |
Why has this pull request never been verified unless I ask (7 months)? |
Because DMS is a repo with not too many maintainers. In my case, I am already following a lot of repos and cannot manage everything. Obviously, this is an OpenSource community and it depends on the community work, if there is not a lot of people involved to a repo, something like this might happen. Anyway, you are right, and this needs to be merged, I see other problems on 12 version, but are not targetted by this change /ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 31b96c9. Thanks a lot for contributing to OCA. ❤️ |
@etobella Thank you so much |
The root directory can't be opened using the contextual action menu (
open
)Impacted versions:
Steps to reproduce:
Current behavior:
Expected behavior: