Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Opening a directory using the right click open action #245

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Zodk2
Copy link

@Zodk2 Zodk2 commented May 28, 2023

The root directory can't be opened using the contextual action menu (open)

Impacted versions:

12.0 and above

Steps to reproduce:

Go to "DMS directories" in the partner form view
Create a new root directory
Right-click and choose `Open`

Current behavior:

Odoo raises an error `TypeError: record is null`

Expected behavior:

Open the directory like if we click on the `Open` button in the right section (Document preview)

@Zodk2
Copy link
Author

Zodk2 commented Jul 27, 2023

@etobella Please, can you verify why the build was not successful

@etobella
Copy link
Member

Probably we need to update the template of dms...

@etobella
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 12.0.

@Zodk2
Copy link
Author

Zodk2 commented Dec 13, 2023

@etobella Please can you check why runboat/build is pending?

@etobella
Copy link
Member

/ocabot rebase

The root directory can't be opened using the contextual action menu (`open`)

Impacted versions:

    12.0 and above

Steps to reproduce:

    Go to "DMS directories" in the partner form view
    Create a new root directory
    Right-click and choose `Open`

Current behavior:

    Odoo raises an error `TypeError: record is null`

Expected behavior:

    Open the directory like if we click on the `Open` button in the right section (Document preview)
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 12.0.

@etobella
Copy link
Member

Just rebase 😉

@Zodk2
Copy link
Author

Zodk2 commented Dec 27, 2023

Why has this pull request never been verified unless I ask (7 months)?

@etobella
Copy link
Member

Because DMS is a repo with not too many maintainers. In my case, I am already following a lot of repos and cannot manage everything. Obviously, this is an OpenSource community and it depends on the community work, if there is not a lot of people involved to a repo, something like this might happen.

Anyway, you are right, and this needs to be merged, I see other problems on 12 version, but are not targetted by this change

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-245-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5fceb13 into OCA:12.0 Dec 27, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 31b96c9. Thanks a lot for contributing to OCA. ❤️

@Zodk2
Copy link
Author

Zodk2 commented Dec 27, 2023

@etobella Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants