Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] delivery_sendcloud_oca #852

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

ByteMeAsap
Copy link

@ByteMeAsap ByteMeAsap commented Jul 9, 2024

delivery_sendcloud_oca module provides sendcloud shipping integration with Odoo

This module mostly implements what's described in https://docs.sendcloud.sc/api/v2/shipping/

Full documentation for developers is in https://docs.sendcloud.sc/.

This module works for the Community Edition as well as the Enterprise Edition.

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This module was moved and migrated from https://github.com/onesteinbv/addons-sendcloud. We (Onestein) have given permission to transition this to the OCA

@rousseldenis
Copy link
Contributor

@ByteMeAsap Could you rename this to delivery_sendcloud_ocaas it exists in Odoo enterprise?

Thanks

@rousseldenis rousseldenis added this to the 17.0 milestone Sep 20, 2024
@ByteMeAsap ByteMeAsap changed the title [17.0][ADD] delivery_sendcloud [17.0][ADD] delivery_sendcloud_oca Sep 20, 2024
@ByteMeAsap ByteMeAsap force-pushed the 17.0-add-delivery_sendcloud branch 2 times, most recently from c909c4c to 7160fea Compare September 20, 2024 10:18
@ByteMeAsap ByteMeAsap force-pushed the 17.0-add-delivery_sendcloud branch 2 times, most recently from ab46bed to fb0ba77 Compare September 20, 2024 15:01
@ByteMeAsap
Copy link
Author

@ByteMeAsap Could you rename this to delivery_sendcloud_ocaas it exists in Odoo enterprise?

Thanks

@rousseldenis , Yes , I have renamed the module. Can you help me with how do I go about resolving conflicts as there have been changes in the 17.0 branch since I had raised the PR a while back?

@ByteMeAsap ByteMeAsap force-pushed the 17.0-add-delivery_sendcloud branch 2 times, most recently from 17824cb to 3b5536f Compare September 26, 2024 05:58
Copy link

@Jan-Onestein Jan-Onestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ByteMeAsap ByteMeAsap force-pushed the 17.0-add-delivery_sendcloud branch 2 times, most recently from 7e0883c to a6364c1 Compare November 5, 2024 08:24
@ByteMeAsap
Copy link
Author

@OCA/delivery-carrier-maintainers, @rousseldenis , can we have this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants