[16.0][IMP] account_reconcile_oca: Add auto-reconcile compatibility (Example: Rule to match invoices/bills) #762
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
…e: Rule to match invoices/bills) TT52146
victoralmau
force-pushed
the
16.0-imp-account_reconcile_oca-TT52146
branch
from
52b89e6 to
839e42d
Compare
…fields Related to odoo/odoo@8948b31 TT52146
pedrobaeza
reviewed
Dec 11, 2024
| @@ -745,6 +754,7 @@ def create(self, mvals): | |||
| models = self.env["account.reconcile.model"].search( | |||
| [ | |||
| ("rule_type", "in", ["invoice_matching", "writeoff_suggestion"]), | |||
| ("company_id", "in", result.mapped("company_id").ids), | |||
There was a problem hiding this comment.
With relation fields, no need to put mapped:
Suggested change
| ("company_id", "in", result.mapped("company_id").ids), | |
| ("company_id", "in", result.company_id.ids), |
| @@ -10,6 +10,16 @@ class TestReconciliationWidget(TestAccountReconciliationCommon): | |||
| @classmethod | |||
| def setUpClass(cls, chart_template_ref=None): | |||
| super().setUpClass(chart_template_ref=chart_template_ref) | |||
| # Auto-disable reconciliation model created automatically with | |||
| # generate_account_reconcile_model() to avoid side effects in tests | |||
| cls.invoice_matching_model = cls.env["account.reconcile.model"].search( | |||
There was a problem hiding this comment.
If it can be more than one, the variable name is not correct
| @@ -999,6 +999,7 @@ def test_partner_name_with_parent(self): | |||
| ) | |||
|
|
|||
| self.invoice_matching_model.active = True | |||
| self.invoice_matching_model.match_text_location_label = False | |||
There was a problem hiding this comment.
Why a separated commit just for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto-reconcile compatibility (Example: Rule to match invoices/bills)
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT52146