Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_payment_return: Add 'is_exchange' value to dict returned in prepare_values_returned_widget method #767

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented Oct 29, 2024

Current behaviour:

  • When having an invoice with returns, there is an error when printing PDF:
Grabacion.de.pantalla.desde.29-10-24.12.26.33.webm

Behaviour with this PR:

  • The PDF is generated corrrectly.
Grabacion.de.pantalla.desde.29-10-24.12.29.16.webm

@sergiobstoj sergiobstoj changed the title [16.0[FIX] account_payment_return: Add 'is_exchange' value to dict returned in prepare_values_returned_widget method [16.0][FIX] account_payment_return: Add 'is_exchange' value to dict returned in prepare_values_returned_widget method Oct 29, 2024
@sergiobstoj sergiobstoj marked this pull request as draft October 29, 2024 11:25
Copy link

@PabloMartFL PabloMartFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review ok!

Whenever you try to print any invoice linked to a payment return, the invoice is printed correctly
https://www.awesomescreenshot.com/video/33069145?key=0ac0e955912d12b3eb4fef069a9c5595

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 29, 2024
@sergiobstoj sergiobstoj marked this pull request as ready for review October 30, 2024 08:24
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergiobstoj
Copy link
Member Author

@pedrobaeza is OK for merge?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

Why don't always putting is_exchange = False? Returned elements are not going to be exchange moves for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants