Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_payment_return_import_iso20022: Amount is not computed … #764

Conversation

carlosdauden
Copy link
Contributor

…when match by payment reference

This commit call supper method without processed lines in self:
cd89ad9
and those proceed lines are not computed here:

self.filtered(lambda x: not x.amount)._compute_amount()
TT51075

…when match by payment reference

This commit call supper method without processed lines in self:
OCA@cd89ad9
and that proceed lines are not computed here:
https://github.com/OCA/account-payment/blob/f6f205acd14a474074e4cd301dad8ed426bcd15c/account_payment_return/models/payment_return.py#L393
TT51075
@carlosdauden
Copy link
Contributor Author

FWPort to 17.0 when merged

@carlosdauden
Copy link
Contributor Author

ping @sergio-teruel @victoralmau

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 8, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-764-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 482e38e into OCA:16.0 Oct 8, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e1c6d07. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-FIX-account_payment_return_import_iso20022-compute_amount branch October 8, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants