[ADD] account_reversal_usability #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IT-Ideas
force-pushed
the
16.0-add-account_reversal_usability-lst
branch
4 times, most recently
from
f51b290
to
821b282
Compare
|
Hello @sbidoul , |
IT-Ideas
force-pushed
the
16.0-add-account_reversal_usability-lst
branch
3 times, most recently
from
3d66cd8
to
ce3e7ec
Compare
sbejaoui
suggested changes
Nov 6, 2023
| _inherit = "account.move" | ||
|
|
||
| to_be_reversed = fields.Boolean( | ||
| compute="_compute_to_be_reversed", |
There was a problem hiding this comment.
IMO, this field can be managed by account.move.reversal
class AccountMoveReversal(models.TransientModel):
_inherit = "account.move.reversal"
def reverse_moves(self):
self.move_ids.write({"to_be_reversed": False})
return super().reverse_moves()There was a problem hiding this comment.
As agreed, we finally go for overriding the account.move._reverse_moves
This commit adds the account_reversal_usability module which purpose is to improve the usability of the move line reverse functionality by adding: * a field that allows tagging a move line as needing to be reversed. The value of the field gets automatically set to False once a reversed entry is made. * a filter in the search view that allows selecting the moves that are flagged as needing to be reversed. * the reverse move in the form view
IT-Ideas
force-pushed
the
16.0-add-account_reversal_usability-lst
branch
from
ce3e7ec
to
7f5f9f2
Compare
sbidoul
approved these changes
Nov 6, 2023
| the field gets automatically set to False once a reversed entry is made. | ||
| * a filter in the search view that allows selecting the moves that are flagged as | ||
| needing to be reversed. | ||
| * the reverse move in the form view""", |
There was a problem hiding this comment.
Do this "big" summary display well in Odoo? Otherwise we can keep (the first sentence may be enough).
|
|
||
| def _reverse_moves(self, default_values_list=None, cancel=False): | ||
| res = super()._reverse_moves(default_values_list, cancel) | ||
| self.to_be_reversed = False |
There was a problem hiding this comment.
Does it now work to assign a value to a set of multiple records at once?
|
Closing this PR as already handled in #1725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the account_reversal_usability module which purpose is to improve the usability of the move line reverse functionality by adding:
Fixes #1761