[14.0][ADD] sale_unreconciled #1283

AaronHForgeFlow · 2021-11-27T11:04:35Z

This module adds a new fields "Unreconciled" on Sales Orders, that allows
to find SO's with unreconciled journal items related.

This module allows to reconcile those SO in a single click. In accounting
settings users will be able to set up a specific account for write-off.

cc @ForgeFlow

ChrisOForgeFlow · 2021-11-30T19:24:25Z

sale_unreconciled/models/account_move_line.py

+        counter_part["debit"] = write_off_vals["credit"]
+        counter_part["credit"] = write_off_vals["debit"]
+        counter_part["amount_currency"] = -write_off_vals["amount_currency"]
+        counter_part["account_id"] = (counterpart_account.id,)


could this throw up a singleton problem?

Perhaps it could, I am adding a warning message just in case

ChrisOForgeFlow · 2021-11-30T19:27:19Z

sale_unreconciled/models/sale_order.py

+             everything is reconciled or that the related accounts do not
+             allow reconciliation""",
+    )
+    is_delivered = fields.Boolean(search="_search_is_delivered")


I don't know if this feature is adequate in this module, because I would understand that it has more to do with the stock than with the reconciliation of the sales order.

The thing is, this field was part of a previous Odoo version and it was used by this module. But I agree it should be out of this module.

The field is removed now.

ChrisOForgeFlow · 2021-11-30T19:31:51Z

sale_unreconciled/models/sale_order.py

+            }
+
+    def action_done(self):
+        if self.unreconciled:


this should be refactored to iterate over self, as in the original implementation there is no self.ensure_one ()

good point! done :)

ChrisOForgeFlow · 2021-11-30T19:33:51Z

sale_unreconciled/models/company.py

+        help="Write-off account to reconcile Unreconciled Sale Orders",
+    )
+
+    sale_reconcile_journal_id = fields.Many2one("account.journal")


A string should be added in the definition, since the field is visible for the configuration

If I don't add a string, it shows as "Sale Reconcile Journal". It think it is correct but I don't mind to put another string if you suggest a different thing.

ChrisOForgeFlow · 2021-11-30T19:36:41Z

sale_unreconciled/views/sale_order_view.xml

+                <filter
+                    name="finance_review"
+                    string="To Review By Finance"
+                    domain="[('unreconciled','=', True), ('invoice_status', '=', 'invoiced'), ('is_delivered', '=', True)]"


This sounds like a more specific customization

Actually, I think this filter would be the most useful utility in this module, as long as the "Unreconciled " filter will show sales that are unreconciled and they are correct. In any case I am removing this because the field is_delivered is removed as well.

Removed the filter, it is a custom thing that is not necessary to be in the module

bosd · 2023-09-30T08:30:59Z

Could you recreate a runboat?

[FIX] sale_unreconciled: ensure the accounting settigs are correct [FIX] sale_unreconciled: assign sale order to the write-off created

…e or not

…concile then assign a matching number [IMP] sale_unreconciled: use the amount resiudal as condition for being unreconciled

… to consider the company of the SO

AaronHForgeFlow · 2023-10-02T07:35:10Z

Just rebased to see if runboat is recreated

bosd

LGTM, Minor nitpicking on grammar.

sale_unreconciled/views/res_config_settings_view.xml

sale_unreconciled/readme/DESCRIPTION.rst

sale_unreconciled/readme/USAGE.rst

sale_unreconciled/tests/test_sale_unreconciled.py

github-actions · 2024-04-21T12:22:43Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

bosd · 2024-04-25T06:47:33Z

@alexis-via you might find this pr interesting.

github-actions · 2024-09-01T12:27:08Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

ChrisOForgeFlow suggested changes Nov 30, 2021

View reviewed changes

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch 2 times, most recently from 2971dcf to 51fe015 Compare December 17, 2021 08:31

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch 2 times, most recently from 9cc3d49 to 85dcf47 Compare May 12, 2022 11:21

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch 2 times, most recently from 794c775 to b603ebc Compare November 21, 2022 16:18

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch 7 times, most recently from f11fef3 to dd5db13 Compare December 28, 2022 19:30

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch from dd5db13 to dd9e3e3 Compare January 11, 2023 11:00

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch from dd9e3e3 to 83a7e4b Compare January 19, 2023 22:14

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch from 4b0d9aa to c3f9c5d Compare February 22, 2023 15:22

AaronHForgeFlow added 12 commits October 2, 2023 09:34

[14.0][ADD] sale_unreconciled

15e4a4d

[FIX] sale_unreconciled: do not create empty write-offs

838c496

[FIX] sale_unreconciled: ensure the accounting settigs are correct [FIX] sale_unreconciled: assign sale order to the write-off created

[14.0][FIX] sale_unreconciled: reconcile exit condition

ad3c4aa

[IMP] sale_unreconciled: allow companies to decide automatic reconcil…

21832a7

…e or not

[FIX]sale_unreconciled: reconcile by currency

4c16aae

[IMP] sale_unreconciled: add tolerance parameter

a390c83

[FIX] sale_unreconciled: if journals have no residual but are full re…

304db72

…concile then assign a matching number [IMP] sale_unreconciled: use the amount resiudal as condition for being unreconciled

[FIX] sale_unreconciled: multicompany for get unreconciled base domain

fe8a228

[FIX] sale_unreconciled: action to see unreconciled journal items has…

36405d2

… to consider the company of the SO

[FIX] sale_unreconciled: account domain

6b3fbb1

[IMP] sale_unreconciled: reconcile by groups

a24f6e1

[IMP] sale_unreconciled: reconcile by groups

397f169

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch from c3f9c5d to 397f169 Compare October 2, 2023 07:34

bosd reviewed Oct 5, 2023

View reviewed changes

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch 3 times, most recently from 3a62797 to d39cc8e Compare October 10, 2023 10:34

[IMP] sale_unreconciled: text

8ec536a

AaronHForgeFlow force-pushed the 14.0-sale_unreconciled branch from d39cc8e to 8ec536a Compare October 10, 2023 10:45

[IMP]sale_unreconciled: reconcile cancelled SO

2c389c1

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024

github-actions bot closed this Oct 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] sale_unreconciled #1283

[14.0][ADD] sale_unreconciled #1283

AaronHForgeFlow commented Nov 27, 2021

ChrisOForgeFlow Nov 30, 2021

AaronHForgeFlow Dec 17, 2021

ChrisOForgeFlow Nov 30, 2021

AaronHForgeFlow Dec 17, 2021

AaronHForgeFlow Nov 21, 2022

ChrisOForgeFlow Nov 30, 2021

AaronHForgeFlow Dec 17, 2021

ChrisOForgeFlow Nov 30, 2021

AaronHForgeFlow Nov 21, 2022

ChrisOForgeFlow Nov 30, 2021

AaronHForgeFlow Dec 17, 2021

AaronHForgeFlow Nov 21, 2022

bosd commented Sep 30, 2023

AaronHForgeFlow commented Oct 2, 2023

bosd left a comment

github-actions bot commented Apr 21, 2024

bosd commented Apr 25, 2024

github-actions bot commented Sep 1, 2024

[14.0][ADD] sale_unreconciled #1283

[14.0][ADD] sale_unreconciled #1283

Conversation

AaronHForgeFlow commented Nov 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bosd commented Sep 30, 2023

AaronHForgeFlow commented Oct 2, 2023

bosd left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 21, 2024

bosd commented Apr 25, 2024

github-actions bot commented Sep 1, 2024