-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] account_analytic_required: Migration to 18.0 #708
Open
peluko00
wants to merge
69
commits into
OCA:18.0
Choose a base branch
from
APSL:18.0-mig-account_analytic_required
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bit=0.0 This is useful in some situations where the tax generates move lines with credit=debit=0.0 with a non-zero tax amount (for instance with tax code VAT-IN-V82-21-EU-S in l10n_be). Without this patch the transaction would be rejected when analytic policy is 'required', since analytic accounts are not propagated through taxes in 6.1.
[RFR] Line length of affected code [UPD] Update pot file with newly generated code strings [ADD] Dutch translations
… two lines before new class.
…ugh when changing analytic account
LGTM, tested in runboat and code review, but please squash administrative commits. |
peluko00
force-pushed
the
18.0-mig-account_analytic_required
branch
from
November 8, 2024 14:44
ae55b3e
to
b2c69d6
Compare
Update import path.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
these cause Warnings during the tests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-13.0/account-analytic-13.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-13-0/account-analytic-13-0-account_analytic_required/
Currently translated at 100.0% (12 of 12 strings) Translation: account-analytic-14.0/account-analytic-14.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-account_analytic_required/ca/
Currently translated at 100.0% (12 of 12 strings) Translation: account-analytic-14.0/account-analytic-14.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-account_analytic_required/es/
…od to avoid warning
Currently translated at 100.0% (12 of 12 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_required/pt_BR/
Currently translated at 100.0% (12 of 12 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_required/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_required/
Currently translated at 100.0% (12 of 12 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_required/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_required Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_required/
peluko00
force-pushed
the
18.0-mig-account_analytic_required
branch
from
November 8, 2024 14:47
b2c69d6
to
aff1e62
Compare
Done. thanks! |
ppyczko
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 18.0
cc https://github.com/APSL 163120
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review
Depends on: