Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oauth2 metadata url #3593

Closed
wants to merge 1 commit into from
Closed

add oauth2 metadata url #3593

wants to merge 1 commit into from

Conversation

AxelNennker
Copy link
Contributor

OAuth2 authorization servers have metadata too. Not only openid connect OPs.

Add a field that allows to specify the AZ metadata URL which then makes specifying "flows" unnecessary.
One of the two fields must be specified but not both.

Signed-off-by: Axel Nennker <[email protected]>
@AxelNennker AxelNennker requested a review from a team as a code owner February 19, 2024 18:14
@handrews
Copy link
Member

@AxelNennker as @darrelmiller mentioned in #3584, we do not change published specifications. Since this cannot be merged as-is, I am going to close it, but that has nothing to do with the merits of the change — I do encourage you to re-open PRs on 3.0.4 or 3.1.1!

Changes that apply to 3.0 should start on the v3.0.4-dev branch, on the versions/3.0.4.md file. We can then propagate those changes to 3.1.1 and 3.2.0. If the change is not applicable to 3.0, then it should start on v3.1.1-dev and versions/3.1.1.md (and it will get propagated to 3.2.0). We are working on improving our process documentation.

In terms of the content, I'm not sure what we do for other fields that are conditionally required, but any changes here should match the style of similar fields.

@handrews handrews closed this Feb 19, 2024
@lornajane
Copy link
Contributor

I also encourage you @AxelNennker to propose this change against the 3.1 branch, it would be good to keep our OAuth support current. @handrews gave an outline of the process in his reply, but please also let us know if you have questions on the process (it isn't intended to be the difficult part!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants