Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

후보자가 답변하는 페이지 제작(call21st 코드 가져옴) #16

Merged
merged 2 commits into from
Mar 21, 2024
Merged

후보자가 답변하는 페이지 제작(call21st 코드 가져옴) #16

merged 2 commits into from
Mar 21, 2024

Conversation

nestiank
Copy link
Collaborator

  • 현재 token 유효성 검사 로직이 없음
  • GA 코드 교체해서 넣음

@nestiank nestiank added the enhancement New feature or request label Mar 21, 2024
@nestiank nestiank requested a review from koremp March 21, 2024 09:25
@nestiank nestiank self-assigned this Mar 21, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
call22nd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 0:00am

@nestiank
후보자가 답변하는 페이지 제작(call21st 코드 가져옴)
83522d1 
- 현재 token 유효성 검사 로직이 없음
@nestiank
Copy link
Collaborator Author

yarn.lock 업데이트를 했는데도 Vercel에서 빌드가 실패합니다. 어떻게 해결하면 좋을까요?

koremp
koremp requested changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@koremp koremp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image `next-ga`를 package dependency에 추가하지 않아서 그런 것 같네요. 추가하고 PR 브랜치에 푸쉬했습니다.

@koremp
Copy link
Collaborator

koremp commented Mar 21, 2024

배포하는 프로세스(CI/CD) 로그에 에러 로그도 나와있어서 참고하시면 돼요

@koremp koremp merged commit 55c2f8e into develop Mar 21, 2024
4 checks passed
@koremp koremp deleted the response-page branch March 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koremp koremp koremp approved these changes

Assignees

@nestiank nestiank

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nestiank @koremp