Added SSL support #545
Merged
Added SSL support #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuSkooler
approved these changes
Jul 20, 2024
NuSkooler
reviewed
Jul 20, 2024
misc/config_template.in.hjson
Outdated
| serverHostname : 'mrc.bottomlessabyss.net' | ||
| serverPort : 5000 | ||
| serverSslPort : 5001 | ||
| useSsl : false |
There was a problem hiding this comment.
Is there any reason not to use TLS by default?
There was a problem hiding this comment.
I usually leave it disabled because in some case it requires an optional library not always installed.
If that is not the case here, please set it as default to true for sure.
There was a problem hiding this comment.
Awesome, updated. Should be fine since Node has TLS and that's all that's really happening in this case
Enable SSL/TLS by default as this is available with node
|
Thanks again @stack-fault ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SSL support between multiplexer and server
Updated templates with new configuration options