capitalize article assessments such as Start, Stub, etc.

Evad37/rater.js does this. Let's copy this practice, so that rater diffs are smaller. For example, the conversion of |class=start to |class=Start in this diff could have been avoided if AFCH had just written |class=Start in the first place: https://en.wikipedia.org/w/index.php?title=Talk:Phare_Circus&diff=next&oldid=1242207529
NovemLinguae · Aug 26, 2024 · b98e4e0 · b98e4e0
1 parent 2523eb9
commit b98e4e0
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/src/modules/core.js b/src/modules/core.js
@@ -1687,7 +1687,7 @@
 			}
 
 			// add disambiguation banner to array
-			if ( newAssessment === 'disambig' ) {
+			if ( newAssessment === 'Disambig' ) {
 				banners.push( '{{WikiProject Disambiguation}}' );
 			}
 

diff --git a/src/modules/submissions.js b/src/modules/submissions.js
@@ -1597,7 +1597,7 @@
 				// If draft is assessed as stub, show stub sorting
 				// interface using User:SD0001/StubSorter.js
 				$afch.find( '#newAssessment' ).on( 'change', function () {
-					const isClassStub = $( this ).val() === 'stub';
+					const isClassStub = $( this ).val() === 'Stub';
 					$afch.find( '#stubSorterWrapper' ).toggleClass( 'hidden', !isClassStub );
 					if ( isClassStub ) {
 						if ( mw.config.get( 'wgDBname' ) !== 'enwiki' ) {
@@ -1622,7 +1622,7 @@
 								$( '#stub-sorter-select' ).addClass( 'afch-input' );
 
 								if ( /\{\{[^{ ]*[sS]tub(\|.*?)?\}\}\s*/.test( pageText ) ) {
-									$afch.find( '#newAssessment' ).val( 'stub' ).trigger( 'chosen:updated' ).trigger( 'change' );
+									$afch.find( '#newAssessment' ).val( 'Stub' ).trigger( 'chosen:updated' ).trigger( 'change' );
 								}
 							} );
 						}

diff --git a/src/templates/tpl-submissions.html b/src/templates/tpl-submissions.html
@@ -73,15 +73,15 @@
 				<option value="" selected></option>
 				<option value="B">B-class</option>
 				<option value="C">C-class</option>
-				<option value="start">Start-class</option>
-				<option value="stub">Stub-class</option>
-				<option value="list">List-class</option>
-				<option value="disambig">Disambig-class</option>
-				<option value="template">Template-class</option>
-				<option value="redirect">Redirect-class</option>
-				<option value="portal">Portal-class</option>
-				<option value="project">Project-class</option>
-				<option value="na">NA-class</option>
+				<option value="Start">Start-class</option>
+				<option value="Stub">Stub-class</option>
+				<option value="List">List-class</option>
+				<option value="Disambig">Disambig-class</option>
+				<option value="Template">Template-class</option>
+				<option value="Redirect">Redirect-class</option>
+				<option value="Portal">Portal-class</option>
+				<option value="Project">Project-class</option>
+				<option value="NA">NA-class</option>
 			</select>
 		</div>
 

diff --git a/tests/test-core.js b/tests/test-core.js
@@ -374,15 +374,15 @@ I have a question. Can you help answer it? –[[User:Novem Linguae|<span style="
 
 	it( 'user selects class = disambiguation', () => {
 		const wikicode = '';
-		const newAssessment = 'disambig';
+		const newAssessment = 'Disambig';
 		const revId = 592681;
 		const isBiography = false;
 		const newWikiProjects = [];
 		const lifeStatus = 'unknown';
 		const subjectName = '';
 		const output = AFCH.addTalkPageBanners( wikicode, newAssessment, revId, isBiography, newWikiProjects, lifeStatus, subjectName );
 		expect( output ).toBe(
-`{{WikiProject banner shell|class=disambig|1=
+`{{WikiProject banner shell|class=Disambig|1=
 {{subst:WPAFC/article|oldid=592681}}
 {{WikiProject Disambiguation}}
 }}`