release 1.2.0-beta.02, fix <select> issue

NotePlan · May 18, 2022 · 089df79 · 089df79
1 parent 019c934
commit 089df79
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/np.Templating/CHANGELOG.md b/np.Templating/CHANGELOG.md
@@ -3,6 +3,10 @@
 ### About np.Templating Plugin
 See Plugin [README](https://github.com/NotePlan/plugins/blob/main/np.Templating/README.md) for details on available commands and use case.
 
+## [1.2.0-beta.02] - 2022-05-17 (mikeerickson)
+
+- fixed issue when template contains folder which has value of `<select>` to prompt user of where new note should be created (@jgclark)
+
 ## [1.2.0-beta.01] - 2022-05-15 (mikeerickson)
 
 - added `templateGroupTemplatesByFolder` setting (default: false)

diff --git a/np.Templating/lib/TemplatingEngine.js b/np.Templating/lib/TemplatingEngine.js
@@ -16,7 +16,6 @@ import FrontmatterModule from '@templatingModules/FrontmatterModule'
 
 import pluginJson from '../plugin.json'
 import { clo, log } from '@helpers/dev'
-import { debug } from '../lib/helpers'
 
 // this is a customized version of `ejs` adding support for async actions (use await in template)
 // review `Test (Async)` template for example`

diff --git a/np.Templating/plugin.json b/np.Templating/plugin.json
@@ -3,7 +3,7 @@
   "noteplan.minAppVersion": "3.5.0",
   "plugin.id": "np.Templating",
   "plugin.name": " 📒 np.Templating -- New 🎉",
-  "plugin.version": "1.2.0-beta.01",
+  "plugin.version": "1.2.0-beta.02",
   "plugin.description": "Templating Plugin for NotePlan",
   "plugin.author": "Mike Erickson (@codedungeon)",
   "plugin.dependencies": [],

diff --git a/np.Templating/src/Templating.js b/np.Templating/src/Templating.js
@@ -311,8 +311,8 @@ export async function templateQuickNote(noteName: string = ''): Promise<void> {
         const { frontmatterBody, frontmatterAttributes } = await NPTemplating.preRender(templateData)
 
         let folder = frontmatterAttributes?.folder.trim() ?? ''
-        if (folder === '') {
-          folder = await NPTemplating.getFolder(folder, 'Select Destination Folder')
+        if (frontmatterAttributes?.folder && frontmatterAttributes.folder.length > 0) {
+          folder = await NPTemplating.getFolder(frontmatterAttributes.folder, 'Select Destination Folder')
         }
 
         let newNoteTitle = ''
@@ -387,8 +387,8 @@ export async function templateMeetingNote(noteName: string = '', templateData: a
         const { frontmatterBody, frontmatterAttributes } = await NPTemplating.preRender(templateData)
 
         let folder = frontmatterAttributes?.folder.trim() ?? ''
-        if (folder === '') {
-          folder = await NPTemplating.getFolder(folder, 'Select Destination Folder')
+        if (frontmatterAttributes?.folder && frontmatterAttributes.folder.length > 0) {
+          folder = await NPTemplating.getFolder(frontmatterAttributes.folder, 'Select Destination Folder')
         }
 
         let newNoteTitle = ''