change bkr for qrr to avoid undefined variable error
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update docs compat
* Fix nonpositive weights bug --------- Co-authored-by: José Bayoán Santiago Calderón <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 91.32% 90.92% -0.41%
==========================================
Files 9 9
Lines 715 716 +1
==========================================
- Hits 653 651 -2
- Misses 62 65 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am afraid I have struggled to reproduce this error in a minimum example, but if the blocks
if qrr < size(F, 2)are accessed on lines 181 and 236 while doing a multinomial regression with nominal or ordinal data, then this triggers an undefined variable error. This is corrected by substitutingqrrforbkron 182 and 237.All tests still pass.