-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar #293
Progress bar #293
Conversation
I tried to modify this a bit to make it more user-friendly, but did not succeed. I tried to move the set default handlers if none are provided, but the defaults are not obeyed for some reason. Also, the vignette does not seem to like the handlers(global=TRUE). We could disable it in the vignette, but that requires an extra argument for every call to explain() so not sure its a good idea (that's the reason for the failing checks) @ungvilde Can you take look at my attempt and see if you can sort it out? See the check_progress.R example script for examples. |
Reverting back to the version where everything is left to the user. The setup we would like to see here does not seem to be possible as of now (ref futureverse/progressr#78) |
progressor
has been added to therun_batch
function incompute_vS
.The progress bar counts how many of the batches have been completed. Even though the batches may have non-equal numbers of elements, and therefore make up different proportions of the total computing time, each batch computation is considered an equally large step of the total computation.
The progress bar will be more accurate if we specify the proportion each batch make of the total computation. See futureverse/progressr#13 for how it might be handled in the future.