-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding custom commands at compile time #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosv
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic.
alloca
was for me a forgotten gem, but seems sweet in this case.
* Don't require the filename to match the command name * Don't require command name to be in uppercase in the JSON file * Allow non-alphanumeric chars in command name * Correct uppercase ordering of commands where ordering would be ambiguos if strncasecmp would be used (e.g. EVAL_RO vs EVALSHA).
zuiderkwast
force-pushed
the
custom-commands
branch
from
February 8, 2024 16:07
6b961e0
to
793024e
Compare
@selcukaltinay FYI |
bjosv
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend gencommands.py with more flexible command handling:
key to find the position of the first key.
space in the command name (instead of as a nested JSON structure).
Additionally, correct uppercase ordering of commands where the ordering would
be ambiguous if strncasecmp() would have been used (e.g. EVAL_RO vs EVALSHA).
This fixes possible failures to find such commands in the lookup table resulting
in "unknown command" errors.
Fixes #162.